suggested reviewers for bugzilla products and components

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

suggested reviewers for bugzilla products and components

glob
an update was pushed to bugzilla.mozilla.org today which allows us to
provide a list of suggestions for the review flag (bug 804708).

this list is on a per-product or per-component basis, with the product's
suggestions being used in the absence of a component specific list.

i have created an initial list on an etherpad using the module owners'
wiki page as a source:

https://bmo.etherpad.mozilla.org/suggested-reviewers

please review and update this document where appropriate.


of course per-component suggestions are not perfect - the reviewer
should be suggested based on the files being touched in the diff.  this
is being worked on by mhoye (bug 774145).


thanks!

--
byron jones - :glob - bugzilla.mozilla.org team -

_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

Marco Bonardo-2
On 18/07/2013 15:33, Byron Jones wrote:
> i have created an initial list on an etherpad using the module owners'
> wiki page as a source:
>
> https://bmo.etherpad.mozilla.org/suggested-reviewers
>
> please review and update this document where appropriate.

Looks like most of Toolkit is missing. Is there a reason or it was just
missed?

-m

_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

glob
Marco Bonardo wrote:

> On 18/07/2013 15:33, Byron Jones wrote:
>> i have created an initial list on an etherpad using the module owners'
>> wiki page as a source:
>>
>> https://bmo.etherpad.mozilla.org/suggested-reviewers
>>
>> please review and update this document where appropriate.
>
> Looks like most of Toolkit is missing. Is there a reason or it was just
> missed?

any product or component which isn't listed on the modules page
(https://wiki.mozilla.org/Modules) will be missing.  feel free to add it.

--
byron jones - :glob - bugzilla.mozilla.org team -

_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

Robert O'Callahan-3
In reply to this post by glob
Hurrah!

How are we going to maintain this going forward? It would be
extra-fantastic if people could easily add or remove themselves as
reviewers for a component. That would help with people going on PTO etc.

Rob
--
Jtehsauts  tshaei dS,o n" Wohfy  Mdaon  yhoaus  eanuttehrotraiitny  eovni
le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o  Whhei csha iids  teoa
stiheer :p atroa lsyazye,d  'mYaonu,r  "sGients  uapr,e  tfaokreg iyvoeunr,
'm aotr  atnod  sgaoy ,h o'mGee.t"  uTph eann dt hwea lmka'n?  gBoutt  uIp
waanndt  wyeonut  thoo mken.o w  *
*
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

glob
Robert O'Callahan wrote:
> How are we going to maintain this going forward?
anyone with the ability to edit the component in bugzilla will be able
to update the suggestions, so once things have settled down you'll have
to file a bugzilla administration bug (or catch someone on irc).
> It would be extra-fantastic if people could easily add or remove
> themselves as reviewers for a component. That would help with people
> going on PTO etc.
that would require more smarts around who could possibly be allowed to
make themselves a suggested reviewer.  i suspect it would be better to
leave the list of suggest reviewers in the hands of a module owner or peer.

day-to-day availability is an issue; there's been some talk of
integration with the PTO system, or (more likely) developing a
bugzilla-specific "away" system.  right now that isn't a priority.  we
are however working on a system to give managers better visibility of
outstanding requests, which should assist when people are on PTO.

--
byron jones - :glob - bugzilla.mozilla.org team -

_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

Till Schneidereit-2
On Fri, Jul 19, 2013 at 7:12 AM, Byron Jones <[hidden email]> wrote:

> Robert O'Callahan wrote:
>
>> How are we going to maintain this going forward?
>>
> anyone with the ability to edit the component in bugzilla will be able to
> update the suggestions, so once things have settled down you'll have to
> file a bugzilla administration bug (or catch someone on irc).
>
>  It would be extra-fantastic if people could easily add or remove
>> themselves as reviewers for a component. That would help with people going
>> on PTO etc.
>>
> that would require more smarts around who could possibly be allowed to
> make themselves a suggested reviewer.  i suspect it would be better to
> leave the list of suggest reviewers in the hands of a module owner or peer.
>
> day-to-day availability is an issue; there's been some talk of integration
> with the PTO system, or (more likely) developing a bugzilla-specific "away"
> system.  right now that isn't a priority.  we are however working on a
> system to give managers better visibility of outstanding requests, which
> should assist when people are on PTO.
>
> People already change their bmo names if they're unavailable. How about
making that explicit and checking for some token in the name string that
automatically removes the person from the list of suggestions?
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

Gervase Markham
In reply to this post by glob
On 19/07/13 09:32, Till Schneidereit wrote:
> making that explicit and checking for some token in the name string that
> automatically removes the person from the list of suggestions?

That would be fairly simple to implement, and would be a good interim
step IMO. We just need something which isn't likely to be accidentally
in anyone's real name. How about "no-request"? (Or if this is only about
reviews and not any other requests, "no-review".)

Gerv

_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

Till Schneidereit-2
On Fri, Jul 19, 2013 at 11:23 AM, Gervase Markham <[hidden email]> wrote:

> On 19/07/13 09:32, Till Schneidereit wrote:
> > making that explicit and checking for some token in the name string that
> > automatically removes the person from the list of suggestions?
>
> That would be fairly simple to implement, and would be a good interim
> step IMO. We just need something which isn't likely to be accidentally
> in anyone's real name. How about "no-request"? (Or if this is only about
> reviews and not any other requests, "no-review".)
>
> Right, I have some personal knowledge of how painful accidental name
matching can be. ;)

"no-review" or "unavailable" would both work, IMO.
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

Justin Wood (Callek)-2
In reply to this post by Robert O'Callahan-3
Byron Jones wrote:

> Robert O'Callahan wrote:
>> How are we going to maintain this going forward?
> anyone with the ability to edit the component in bugzilla will be able
> to update the suggestions, so once things have settled down you'll have
> to file a bugzilla administration bug (or catch someone on irc).
>> It would be extra-fantastic if people could easily add or remove
>> themselves as reviewers for a component. That would help with people
>> going on PTO etc.
> that would require more smarts around who could possibly be allowed to
> make themselves a suggested reviewer.  i suspect it would be better to
> leave the list of suggest reviewers in the hands of a module owner or peer.
>
> day-to-day availability is an issue; there's been some talk of
> integration with the PTO system, or (more likely) developing a
> bugzilla-specific "away" system.  right now that isn't a priority.  we
> are however working on a system to give managers better visibility of
> outstanding requests, which should assist when people are on PTO.
>

Just to say, it would be good for "manager system" to be able to exclude
certain components.

I get asked all the time for reviews on my volunteer activities, which
obviously have a longer lead time on answers, and some of said bugs I
also answer with "I don't have any interest in this, please explain your
reasoning" type of comments where my r? stays outstanding for longer.
similar for said product's needinfo's (including self-pointed needinfo).

Having my manager in Mozilla have to always trudge through those will
make it not-so-useful for him and me :-)

[I recognize my use-case here is not-so-common though]

--
~Justin Wood (Callek)
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: suggested reviewers for bugzilla products and components

Philip Chee
On 22/07/2013 03:50, Justin Wood (Callek) wrote:

> Byron Jones wrote:
>> Robert O'Callahan wrote:
>>> How are we going to maintain this going forward?
>> anyone with the ability to edit the component in bugzilla will be able
>> to update the suggestions, so once things have settled down you'll have
>> to file a bugzilla administration bug (or catch someone on irc).
>>> It would be extra-fantastic if people could easily add or remove
>>> themselves as reviewers for a component. That would help with people
>>> going on PTO etc.
>> that would require more smarts around who could possibly be allowed to
>> make themselves a suggested reviewer.  i suspect it would be better to
>> leave the list of suggest reviewers in the hands of a module owner or peer.
>>
>> day-to-day availability is an issue; there's been some talk of
>> integration with the PTO system, or (more likely) developing a
>> bugzilla-specific "away" system.  right now that isn't a priority.  we
>> are however working on a system to give managers better visibility of
>> outstanding requests, which should assist when people are on PTO.
>>
>
> Just to say, it would be good for "manager system" to be able to exclude
> certain components.
>
> I get asked all the time for reviews on my volunteer activities, which
> obviously have a longer lead time on answers, and some of said bugs I
> also answer with "I don't have any interest in this, please explain your
> reasoning" type of comments where my r? stays outstanding for longer.
> similar for said product's needinfo's (including self-pointed needinfo).
>
> Having my manager in Mozilla have to always trudge through those will
> make it not-so-useful for him and me :-)
>
> [I recognize my use-case here is not-so-common though]

YOu could create an alternative Bugzilla identity e.g.
[hidden email] for your paid work.

Phil

--
Philip Chee <[hidden email]>, <[hidden email]>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning