stylo crashtest job is green

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

stylo crashtest job is green

Cameron McCormack-4
With the latest merge of mozilla-central into incubator/stylo, the
crashtest job is finally green.

https://treeherder.mozilla.org/#/jobs?repo=stylo&revision=8ebbde564daf4f7019d874e4b888bd670c81e6cc

I recommend that people writing stylo patches do try runs so that we can
avoid it regressing.  If it goes orange to due to a test now passing
(i.e. now not asserting), please remove the asserts-if(stylo,...)
annotation in the same patch and mark the noted bug in the crashtest
manifest as fixed.  If it fails due to an issue with your patch, please
(ideally) fix it before landing, or either

(a) if it's crashing, mark the test as skip-if(stylo) and file a bug
blocking https://bugzilla.mozilla.org/show_bug.cgi?id=1289964 to fix it,
or
(b) if it's asserting, add or extend an asserts-if(stylo,...)
annotation, and file a bug blocking
https://bugzilla.mozilla.org/show_bug.cgi?id=1324620 to fix it.

There might be a dependent of one of those two bugs that can be reused
for a new test skip/failure annotation.

Of course this doesn't help with regressions that come from
mozilla-central and servo merges that weren't stylo patches, but I will
try to get those fixed before pushing broken merges.

I will look at reftests next.
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout
Reply | Threaded
Open this post in threaded view
|

Re: stylo crashtest job is green

Jet Villegas-2
\o/

Awesome work, Cam and Stylo Team!

--Jet

On Tuesday, January 3, 2017, Cameron McCormack <[hidden email]> wrote:

> With the latest merge of mozilla-central into incubator/stylo, the
> crashtest job is finally green.
>
> https://treeherder.mozilla.org/#/jobs?repo=stylo&revision=
> 8ebbde564daf4f7019d874e4b888bd670c81e6cc
>
> I recommend that people writing stylo patches do try runs so that we can
> avoid it regressing.  If it goes orange to due to a test now passing
> (i.e. now not asserting), please remove the asserts-if(stylo,...)
> annotation in the same patch and mark the noted bug in the crashtest
> manifest as fixed.  If it fails due to an issue with your patch, please
> (ideally) fix it before landing, or either
>
> (a) if it's crashing, mark the test as skip-if(stylo) and file a bug
> blocking https://bugzilla.mozilla.org/show_bug.cgi?id=1289964 to fix it,
> or
> (b) if it's asserting, add or extend an asserts-if(stylo,...)
> annotation, and file a bug blocking
> https://bugzilla.mozilla.org/show_bug.cgi?id=1324620 to fix it.
>
> There might be a dependent of one of those two bugs that can be reused
> for a new test skip/failure annotation.
>
> Of course this doesn't help with regressions that come from
> mozilla-central and servo merges that weren't stylo patches, but I will
> try to get those fixed before pushing broken merges.
>
> I will look at reftests next.
> _______________________________________________
> dev-tech-layout mailing list
> [hidden email] <javascript:;>
> https://lists.mozilla.org/listinfo/dev-tech-layout
>
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout
Reply | Threaded
Open this post in threaded view
|

Re: stylo crashtest job is green

Bobby Holley-2
This is great! Let's keep it green. :-)

On Tue, Jan 3, 2017 at 11:25 PM, Jet Villegas <[hidden email]> wrote:

> \o/
>
> Awesome work, Cam and Stylo Team!
>
> --Jet
>
> On Tuesday, January 3, 2017, Cameron McCormack <[hidden email]> wrote:
>
> > With the latest merge of mozilla-central into incubator/stylo, the
> > crashtest job is finally green.
> >
> > https://treeherder.mozilla.org/#/jobs?repo=stylo&revision=
> > 8ebbde564daf4f7019d874e4b888bd670c81e6cc
> >
> > I recommend that people writing stylo patches do try runs so that we can
> > avoid it regressing.  If it goes orange to due to a test now passing
> > (i.e. now not asserting), please remove the asserts-if(stylo,...)
> > annotation in the same patch and mark the noted bug in the crashtest
> > manifest as fixed.  If it fails due to an issue with your patch, please
> > (ideally) fix it before landing, or either
> >
> > (a) if it's crashing, mark the test as skip-if(stylo) and file a bug
> > blocking https://bugzilla.mozilla.org/show_bug.cgi?id=1289964 to fix it,
> > or
> > (b) if it's asserting, add or extend an asserts-if(stylo,...)
> > annotation, and file a bug blocking
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1324620 to fix it.
> >
> > There might be a dependent of one of those two bugs that can be reused
> > for a new test skip/failure annotation.
> >
> > Of course this doesn't help with regressions that come from
> > mozilla-central and servo merges that weren't stylo patches, but I will
> > try to get those fixed before pushing broken merges.
> >
> > I will look at reftests next.
> > _______________________________________________
> > dev-tech-layout mailing list
> > [hidden email] <javascript:;>
> > https://lists.mozilla.org/listinfo/dev-tech-layout
> >
> _______________________________________________
> dev-tech-layout mailing list
> [hidden email]
> https://lists.mozilla.org/listinfo/dev-tech-layout
>
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout