Triage for Extension Issues

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Triage for Extension Issues

Clint Talbert-3
Hi Quality People,

Currently when we find a bug that is in an extension we mark it as
'invalid'.  I think that is the right approach w.r.t. bugzilla, but it
has the negative problem that this issue is now essentially untrackable
in bugzilla.  It would be far more useful to move these bugs into a
queue that the Add-Ons team can then use to drive fixes to popular
extensions.

We have an "extension compatibility" component in the Firefox Bugzilla
Product.  So, I propose that we do the following when we encounter a bug
in an extension:

* Triage the bug as being in an extension (try to reproduce, reproduce
in safe mode, determine which extension is causing the problem).
* Move the bug to the Firefox->Extension Compatibility area
* Leave the bug open and put in a comment that the AMO reviewers/editors
will take this up with the developer of the extension (if possible).

How does that sound?

Clint
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Triage for Extension Issues

majken@gmail.com
On Jul 1, 5:10 pm, Clint Talbert <[hidden email]> wrote:

> Hi Quality People,
>
> Currently when we find a bug that is in an extension we mark it as
> 'invalid'.  I think that is the right approach w.r.t. bugzilla, but it
> has the negative problem that this issue is now essentially untrackable
> in bugzilla.  It would be far more useful to move these bugs into a
> queue that the Add-Ons team can then use to drive fixes to popular
> extensions.
>
> We have an "extension compatibility" component in the Firefox Bugzilla
> Product.  So, I propose that we do the following when we encounter a bug
> in an extension:
>
> * Triage the bug as being in an extension (try to reproduce, reproduce
> in safe mode, determine which extension is causing the problem).
> * Move the bug to the Firefox->Extension Compatibility area
> * Leave the bug open and put in a comment that the AMO reviewers/editors
> will take this up with the developer of the extension (if possible).
>
> How does that sound?
>
> Clint

I think this is a great idea on the surface. The problem is if we
implement a process for this, does this mean that we're encouraging
people to report bugs with extensions on bugzilla?  I think we need to
be careful to restrict this to extensions that break Firefox. People
reporting a bug in an extensions own functions should still be marked
invalid, though they can be encouraged to report the problem by
reviewing the extension.

In terms of extensions that break Firefox functions, like the old
Skype version and the toolbar, I think this is definitely useful to
have a process and an area for this.  This will be good for SUMO, too,
as we do need to keep track of what extensions can cause what
problems.  It's also a good idea in terms of determining early if a
version of an extension needs to be blocklisted.

I think it'd be better to make a new component, or use the
blocklisting component though, than using extension compatibility.
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Triage for Extension Issues

Seth Wagoner
From this particular extension developers perspective (we built
Interclue, Lazarus, various others), this seems like a great idea, but
the key people you need to hear from are the AMO Editors and Admins,
who have a broader perspective across the ecosystem.

WRT Majken's concerns:

(1) I think given the category is "extension compatibility" you are
unlikely to get too many internal extension bugs repored, but you
might get some that are caused by interactions between multiple
extensions. Which might be something you'd want to avoid, but you
should consider what should happen if you get a bug along the lines of
"extension X breaks extension Y, but only on Firefox 3.6.x".

(2) I would avoid encouraging users to report a bug by reviewing the
extension - developers hate that because we don't have access to their
email address and we can't follow up with questions to help debug the
issue. It's actually actively discouraged in the AMO review
guidelines. Most of the active extensions have a support contact
entered on their AMO page (URL, email address, or both) and users
should be encouraged to use that instead. The template reply could be
something like:

"We can't help with this particular bug because it's not a
compatibility issue but rather a bug in the extension. Please contact
the author(s) of the extension, using the contact details usually
found near the bottom of the download page for the extension on
addons.mozilla.org, and/or on the add-on's website. Please note that
using the reviews system on addons.mozilla.org to report bugs is [not
encouraged|actively discouraged]."

Cheers,
Seth.
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Triage for Extension Issues

Martijn-4
In reply to this post by Clint Talbert-3
2009/7/1 Clint Talbert <[hidden email]>:

> Hi Quality People,
>
> Currently when we find a bug that is in an extension we mark it as 'invalid'.  I think that is the right approach w.r.t. bugzilla, but it has the negative problem that this issue is now essentially untrackable in bugzilla.  It would be far more useful to move these bugs into a queue that the Add-Ons team can then use to drive fixes to popular extensions.
>
> We have an "extension compatibility" component in the Firefox Bugzilla Product.  So, I propose that we do the following when we encounter a bug in an extension:
>
> * Triage the bug as being in an extension (try to reproduce, reproduce in safe mode, determine which extension is causing the problem).
> * Move the bug to the Firefox->Extension Compatibility area
> * Leave the bug open and put in a comment that the AMO reviewers/editors will take this up with the developer of the extension (if possible).
>
> How does that sound?


This sounds like a good idea to me.
I'm not completely sure about that last point. It seems to me anyone
who's willing to take it up with the developer of the extension (if
possible) should be able to do that. So a comment in the relevant bug,
reflecting that he/she contacted the extension developer should
suffice.

Regards,
Martijn

>
> Clint
> _______________________________________________
> dev-quality mailing list
> [hidden email]
> https://lists.mozilla.org/listinfo/dev-quality
>



--
Martijn Wargers - Help Mozilla!
http://quality.mozilla.org/
http://wiki.mozilla.org/Mozilla_QA_Community
irc://irc.mozilla.org/qa - /nick mw22
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Triage for Extension Issues

Clint Talbert-3
In reply to this post by Clint Talbert-3
Thanks to everyone for all your responses.  Looking through this, I
think that we will go ahead with this proposal.  I've decided to change
a few things with the approach based on your thoughts.  So, let me
outline the new proposal:

== The Proposal ==
* I'll file a bug for AMO to get a bugzilla query link on the Developer
Dashboard so to help developers find these bugs.

* We're not going to encourage people to file add-on bugs here.  We will
always encourage people to send the add-on developer feedback through
the proper means for that add-on (email, AMO page, website etc).  This
will only pertain to bugs that get reported as "Firefox" bugs but then
turn out to be extension bugs.

And now for the triage part:
* When a bug comes in that might be an extension issue, the triager will:
1. Determine if the problem is in the extension or in Firefox
2. If the bug appears to be in the extension, then:
2a. Move the bug to Extension->Compatibility area
2b. Change the summary of the bug to prepend the extension's name in
brackets so that a simple search can later find it
2c. Move the bug to be "INVALID" since it is against an extension and
not the Firefox product
2d. Leave a note to the reporter to contact that add-on developer about
the issue, and invite the reporter to comment in the bug once they make
that contact.

Now, if the bug is not a problem with an extension, then it should be
filed normally as a product bug would normally be filed.

If the add-on developer determines that his/her code is actually
correct, and this is a Firefox bug, then the bug should be re-opened and
triaged as a normal product bug would be (probably moved to another
component, more information added etc).

How's that sound? (Last Call for feedback...)

Clint

On 7/1/09 2:10 PM, Clint Talbert wrote:

> Hi Quality People,
>
> Currently when we find a bug that is in an extension we mark it as
> 'invalid'. I think that is the right approach w.r.t. bugzilla, but it
> has the negative problem that this issue is now essentially untrackable
> in bugzilla. It would be far more useful to move these bugs into a queue
> that the Add-Ons team can then use to drive fixes to popular extensions.
>
> We have an "extension compatibility" component in the Firefox Bugzilla
> Product. So, I propose that we do the following when we encounter a bug
> in an extension:
>
> * Triage the bug as being in an extension (try to reproduce, reproduce
> in safe mode, determine which extension is causing the problem).
> * Move the bug to the Firefox->Extension Compatibility area
> * Leave the bug open and put in a comment that the AMO reviewers/editors
> will take this up with the developer of the extension (if possible).
>
> How does that sound?
>
> Clint

_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Triage for Extension Issues

Tanner M. Young
In reply to this post by Martijn-4
> How's that sound? (Last Call for feedback...)
>
> Clint

Sounds good to me.  I saw we go with it.

Tanner

_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Triage for Extension Issues

Tony Chung-2
In reply to this post by Clint Talbert-3
Clint Talbert wrote:
>
> And now for the triage part:
> * When a bug comes in that might be an extension issue, the triager will:
> 1. Determine if the problem is in the extension or in Firefox
> 2. If the bug appears to be in the extension, then:
> 2a. Move the bug to Extension->Compatibility area

Did you mean "Firefox::Extension Compatibility"? opposed to Ext->compat?
> 2b. Change the summary of the bug to prepend the extension's name in
> brackets so that a simple search can later find it
Some of these extension names may get a little long to put into the []?
Maybe a different common word in the title, or maybe use a common
keyword or whiteboard?
> 2c. Move the bug to be "INVALID" since it is against an extension and
> not the Firefox product
> 2d. Leave a note to the reporter to contact that add-on developer about
> the issue, and invite the reporter to comment in the bug once they make
> that contact.
Maybe an additional step is for the reporter to include the add-on
developer contact information directly in the comment as well, so others
can touch base also.
>
> Now, if the bug is not a problem with an extension, then it should be
> filed normally as a product bug would normally be filed.

Looks great otherwise.

Tony
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality