Too many warning lines during |make mozmill| : WARNING: 'NS_FAILED(rv)', file /NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp, line 171

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Too many warning lines during |make mozmill| : WARNING: 'NS_FAILED(rv)', file /NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp, line 171

ISHIKAWA,chiaki
Hi,

After updating my local copy of comm-central,
I found four errors during |make mozmill| test run from the barely
modified source tree. (I needed to apply a few modifications to build
in order to accommodate my strict GCC warning/error options.)
I suspect these four are related to calendar. I leave them aside for a
moment.

What surprised me is the large number of a new warning line.

[Main Thread] WARNING: 'NS_FAILED(rv)', file
/NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp,
line 171

This happened more than 7,000 times.

The following is the most often seen warning during |make mozmill| in the
descending order of appearances. (Top 20)
I list the similar data from June run for comparison following this.

========================================
Warning list (from 1st December)
========================================
(I found the new warning very informative although I am not sure what
to make of it in TB's context. It may have a significance when we do
HTML rendering in TB...:
WARNING: Found a principal with no URI, assuming third-party request:
file /NREF-COMM-CENTRAL/mozilla/dom/base/ThirdPartyUtil.cpp, line 226
)


7149: Main Thread] WARNING: 'NS_FAILED(rv)', file
/NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp,
line 171
2064: Main Thread] WARNING: XPCOM objects created/destroyed from static
ctor/dtor: file /NREF-COMM-CENTRAL/mozilla/xpcom/base/nsTraceRefcnt.cpp,
line 189
1323: Main Thread] WARNING: '!mMainThread', file
/NREF-COMM-CENTRAL/mozilla/xpcom/threads/nsThreadManager.cpp, line 457
1120: Main Thread] WARNING: Failed to remove an override style sheet:
'NS_SUCCEEDED(rv)', file
/NREF-COMM-CENTRAL/mozilla/editor/libeditor/HTMLEditor.cpp, line 372
1120: Main Thread] WARNING: '!presShell', file
/NREF-COMM-CENTRAL/mozilla/editor/libeditor/HTMLEditor.cpp, line 3212
1060: Main Thread] WARNING: Failed to retarget HTML data delivery to the
parser thread.: file
/NREF-COMM-CENTRAL/mozilla/parser/html/nsHtml5StreamParser.cpp, line 967
406: Main Thread] WARNING: Found a principal with no URI, assuming
third-party request: file
/NREF-COMM-CENTRAL/mozilla/dom/base/ThirdPartyUtil.cpp, line 226
315: Main Thread] WARNING: '!mTextEditor', file
/NREF-COMM-CENTRAL/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp,
line 669
315: Main Thread] WARNING: '!mTextEditor', file
/NREF-COMM-CENTRAL/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp,
line 1575
308: Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result
0x80550006: file
/NREF-COMM-CENTRAL/mozilla/comm/mailnews/local/src/nsMailboxService.cpp,
line 684
308: Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result
0x80550006: file
/NREF-COMM-CENTRAL/mozilla/comm/mailnews/base/util/nsMsgDBFolder.cpp,
line 5186
280: Main Thread] WARNING: HTMLEditRules::BeforeEdit() failed to handle
something: 'NS_SUCCEEDED(rv)', file
/NREF-COMM-CENTRAL/mozilla/editor/libeditor/HTMLEditor.cpp, line 3576
172: Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file
/NREF-COMM-CENTRAL/mozilla/layout/base/nsDocumentViewer.cpp, line 3297
167: Main Thread] WARNING: We should have hit the document element...:
file /NREF-COMM-CENTRAL/mozilla/layout/xul/BoxObject.cpp, line 146
156: Main Thread] WARNING: NS_ENSURE_TRUE(name) failed: file
/NREF-COMM-CENTRAL/mozilla/dom/base/nsDOMAttributeMap.cpp, line 305
155: Main Thread] WARNING: NS_ENSURE_TRUE(msgDocShellItem) failed: file
/NREF-COMM-CENTRAL/mozilla/comm/mailnews/base/src/nsMsgWindow.cpp, line 87
103: Main Thread] WARNING: '!aNode', file
/NREF-COMM-CENTRAL/mozilla/editor/libeditor/EditorBase.cpp, line 3455
79: Main Thread] WARNING: '!gThread', file
/NREF-COMM-CENTRAL/mozilla/xpcom/threads/nsTimerImpl.cpp, line 299
63: Main Thread] WARNING: unable to post continuation event: file
/NREF-COMM-CENTRAL/mozilla/xpcom/io/nsStreamUtils.cpp, line 445
42: Main Thread] WARNING: Perhaps, <br> element position has been moved
to different point by mutation observer: 'currentPoint ==
pointToInsert', file
/NREF-COMM-CENTRAL/mozilla/editor/libeditor/HTMLEditRules.cpp, line 1444


========================================
Warning list from June (based on April source tree).
========================================
(The folloing was the top-20 produced in my local |make mozmill| run using a
binary produced from comm-central source tree updated in April this year.)


1656: Main Thread] WARNING: XPCOM objects created/destroyed from static
ctor/dtor: file
/NREF-COMM-CENTRAL/comm-central/mozilla/xpcom/base/nsTraceRefcnt.cpp,
line 194
1092: Main Thread] WARNING: NS_ENSURE_TRUE(ps) failed: file
/NREF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/HTMLEditor.cpp,
line 2874
1064: Main Thread] WARNING: '!mMainThread', file
/NREF-COMM-CENTRAL/comm-central/mozilla/xpcom/threads/nsThreadManager.cpp,
line 517
1048: Main Thread] WARNING: Failed to retarget HTML data delivery to the
parser thread.: file
/NREF-COMM-CENTRAL/comm-central/mozilla/parser/html/nsHtml5StreamParser.cpp,
line 1009
308: Main Thread] WARNING: '!mTextEditor', file
/NREF-COMM-CENTRAL/comm-central/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp,
line 723
308: Main Thread] WARNING: '!mTextEditor', file
/NREF-COMM-CENTRAL/comm-central/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp,
line 1728
289: Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result
0x80550006: file
/NREF-COMM-CENTRAL/comm-central/mailnews/local/src/nsMailboxService.cpp,
line 672
289: Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result
0x80550006: file
/NREF-COMM-CENTRAL/comm-central/mailnews/base/util/nsMsgDBFolder.cpp,
line 5188
273: Main Thread] WARNING: NS_ENSURE_TRUE(sheet) failed: file
/NREF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/HTMLEditor.cpp,
line 2868
208: Main Thread] WARNING: NS_ENSURE_TRUE(ioService) failed: file
/NREF-COMM-CENTRAL/comm-central/mailnews/base/util/nsMsgMailNewsUrl.cpp,
line 622
208: Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result
0x8000FFFF: file
/NREF-COMM-CENTRAL/comm-central/mailnews/local/src/nsMailboxUrl.cpp,
line 181
170: Main Thread] WARNING: We should have hit the document element...:
file /NREF-COMM-CENTRAL/comm-central/mozilla/layout/xul/BoxObject.cpp,
line 174
152: Main Thread] WARNING: NS_ENSURE_TRUE(msgDocShellItem) failed: file
/NREF-COMM-CENTRAL/comm-central/mailnews/base/src/nsMsgWindow.cpp, line 90
149: Main Thread] WARNING: NS_ENSURE_TRUE(name) failed: file
/NREF-COMM-CENTRAL/comm-central/mozilla/dom/base/nsDOMAttributeMap.cpp,
line 327
102: Main Thread] WARNING: NS_ENSURE_TRUE(aNode) failed: file
/NREF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/EditorBase.cpp,
line 3939
70: Main Thread] WARNING: unable to post continuation event: file
/NREF-COMM-CENTRAL/comm-central/mozilla/xpcom/io/nsStreamUtils.cpp, line 490
62: Main Thread] WARNING: NS_ENSURE_TRUE(aSecondURI) failed: file
/NREF-COMM-CENTRAL/comm-central/mozilla/dom/base/ThirdPartyUtil.cpp, line 98
41: Main Thread] WARNING: Perhaps, <br> element position has been moved
to different point by mutation observer: 'currentPoint ==
pointToInsert', file
/NREF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/HTMLEditRules.cpp,
line 1437
39: Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file
/NREF-COMM-CENTRAL/comm-central/mozilla/xpcom/threads/nsThread.cpp, line 791


Should I report this to bugzilla?

7K warning lines are a bit too many IMHO.

OTOH, FF may not produce the lines: it all depends on how the
asynchronous
I/O is handled by an application...
So I wonder to which component/product  I should report this.

Chiaki

PS: I am testing my local patches (for buffered write and additionally for
handling short read from remote servers) for TB and trying to adapt
the patches to the latest tree.

I was impressed after seeing there were no errors in |make mozmill|
test in June using the source tree fetched in April. (I would like to
thank jorg, aceman, wayne and others for keeping the C-C source tree
in such a good condition.).

I happily tried to update the local patches against the source that was
fetched in July, and found that this caused more than 50 errors.
For the last few months I scratched my head after checking the patch
carefully but could not
find any tell-tale signs of problems that can be co-related to the
errors produced in |make mozill|. The issue must be very subtle or a
brown-bag type bug that escaped my search so far.

Figuring that I should make sure my local patches do not diverge much
from the current source tree, I fetched the source tree again on Dec 1st,
and plan to adapt the patches and investigate the problems using the
current tree. This is what I am doing right now and noticed these
warnings.

I need to produce the base log against which I compare the
log produced by TB with my patches.
The less clutter in the log, the easier my analysis of my patch
problem becomes.  This is why I posted my message above.


_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Too many warning lines during |make mozmill| : WARNING: 'NS_FAILED(rv)', file /NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp, line 171

Jörg Knobloch
On 12/2/2018 9:07 AM, ISHIKAWA,chiaki wrote:
> [Main Thread] WARNING: 'NS_FAILED(rv)', file
> /NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp,
> line 171
>
> This happened more than 7,000 times.

All we can do is file a bug with the subject:

Extremely spammy warning |WARNING: 'NS_FAILED(rv)', file
[snip]/xpcom/io/NonBlockingAsyncInputStream.cpp, line 171|

like I did now in https://bugzilla.mozilla.org/show_bug.cgi?id=1511692.

It would be good to NI the person who landed that code (as I did).

Jörg.

_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Too many warning lines during |make mozmill| : WARNING: 'NS_FAILED(rv)', file /NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp, line 171

ISHIKAWA,chiaki
On 2018/12/02 18:22, Jörg Knobloch wrote:

> On 12/2/2018 9:07 AM, ISHIKAWA,chiaki wrote:
>> [Main Thread] WARNING: 'NS_FAILED(rv)', file
>> /NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp,
>> line 171
>>
>> This happened more than 7,000 times.
>
> All we can do is file a bug with the subject:
>
> Extremely spammy warning |WARNING: 'NS_FAILED(rv)', file
> [snip]/xpcom/io/NonBlockingAsyncInputStream.cpp, line 171|
>
> like I did now in https://bugzilla.mozilla.org/show_bug.cgi?id=1511692.
>
> It would be good to NI the person who landed that code (as I did).
>
> Jörg.
>

Thank you for filing the bug.

I could not access dxr.mozilla.org during the day when I sent out the
previous e-mail.
Maybe DXR was in maintenance mode?

So I was not so sure when that warning was introduced by whom.

It seems it entered the tree in less than a week ago.

Let's hope it is not TB calling the routine in a non-optimal manner, but
the checking is indeed verbose.

Thank you again.

CI


_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Too many warning lines during |make mozmill| : WARNING: 'NS_FAILED(rv)', file /NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp, line 171

Jörg Knobloch
On 02/12/2018 15:10, ISHIKAWA,chiaki wrote:
> I could not access dxr.mozilla.org during the day when I sent out the
> previous e-mail.
> Maybe DXR was in maintenance mode?

Try https://searchfox.org/, DXR doesn't seem to be working today.

_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Too many warning lines during |make mozmill| : WARNING: 'NS_FAILED(rv)', file /NREF-COMM-CENTRAL/mozilla/xpcom/io/NonBlockingAsyncInputStream.cpp, line 171

ISHIKAWA,chiaki
On 2018/12/02 23:53, Jörg Knobloch wrote:
> On 02/12/2018 15:10, ISHIKAWA,chiaki wrote:
>> I could not access dxr.mozilla.org during the day when I sent out the
>> previous e-mail.
>> Maybe DXR was in maintenance mode?
>
> Try https://searchfox.org/, DXR doesn't seem to be working today.
>
>
OK, this will do. Thank you.

Since the past weekend, I get


  Internal Server Error

The server encountered an internal error and was unable to complete your
request. Either the server is overloaded or there is an error in the
application.

when I access dxr.mozilla.org.
Maybe I should report this or I wonder if dxr is decomissioned.


_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird