Tests that aren't compiled in netwerk/test

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Tests that aren't compiled in netwerk/test

polly.shaw
Hello,

This is my first post so sorry if I do anything inappropriate. Also please let me know if I do!

I have been looking at netwerk because I am thinking of implementing DHCP proxy auto-detect as described in bug 356831. There are some cpp files in netwerk/test which don't seem to be compiled as they're not in the local moz.build (e.g. TestCachPrefixKeyParser.cpp), and I wondered if they should be removed? There is a bug that I thought might be relevant:

https://bugzilla.mozilla.org/show_bug.cgi?id=1313752 

However I didn't comment on that bug as it is marked as resolved, and reading the etiquette guidelines, I thought it seemed as though I should post here if unsure as to whether to comment.

Polly
_______________________________________________
dev-builds mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-builds
Reply | Threaded
Open this post in threaded view
|

Re: Tests that aren't compiled in netwerk/test

Ted Mielczarek-2
On Thu, Jan 5, 2017, at 07:43 AM, [hidden email] wrote:
> Hello,
>
> This is my first post so sorry if I do anything inappropriate. Also
> please let me know if I do!

Hi there!

> I have been looking at netwerk because I am thinking of implementing DHCP
> proxy auto-detect as described in bug 356831. There are some cpp files in
> netwerk/test which don't seem to be compiled as they're not in the local
> moz.build (e.g. TestCachPrefixKeyParser.cpp), and I wondered if they
> should be removed? There is a bug that I thought might be relevant:

If they're not even listed in moz.build then they're not doing anything
but wasting people's time showing up in code search results. We should
definitely remove them!

> https://bugzilla.mozilla.org/show_bug.cgi?id=1313752 
>
> However I didn't comment on that bug as it is marked as resolved, and
> reading the etiquette guidelines, I thought it seemed as though I should
> post here if unsure as to whether to comment.

It's not out of the ordinary to comment on a closed bug to note that
something was missing from the patch that landed, but it's also not the
most useful because not everyone pays attention to closed bugs. We do
sometimes reopen bugs, usually if the patch gets backed out because it
was broken in some significant way. In this case this is just something
that the developer missed, so the usual workflow would be to file a new
bug and put the original bug in the new bug's "depends on" field. That
way people following the original bug can get a bugzilla notification,
but we've got a fresh bug to ensure the issue doesn't get lost in the
shuffle. I'd recommend filing a new bug in Core: Networking, making it
depend on bug 1313752 and CCing the original patch author
([hidden email]).

If any of that is confusing I'm happy to help (I sometimes forget how
overwhelming Bugzilla can be to people who haven't developed Stockholm
syndrome with it can be).

If you need any additional help with your netwerk changes feel free to
drop into irc.mozilla.org! #introduction has beginner-friendly help,
#developers has lots of Gecko developers, and #necko has lots of network
developers.

Regards,
-Ted
_______________________________________________
dev-builds mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-builds
Reply | Threaded
Open this post in threaded view
|

Re: Tests that aren't compiled in netwerk/test

Boris Zbarsky
In reply to this post by polly.shaw
On 1/5/17 9:51 AM, Ted Mielczarek wrote:
> If they're not even listed in moz.build then they're not doing anything
> but wasting people's time showing up in code search results. We should
> definitely remove them!

Or start running them.  It looks to me like this test was meant to be
run (added in
https://hg.mozilla.org/mozilla-central/rev/6109876e1a22e20466c08c5519f23d38d35a7a51 
) but the relevant moz.build changes just didn't get made or something.

> I'd recommend filing a new bug in Core: Networking, making it
> depend on bug 1313752 and CCing the original patch author
> ([hidden email]).

cc the patch author from bug 968593 (":mayhemer" in Bugzilla) too, please.

-Boris
_______________________________________________
dev-builds mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-builds
Reply | Threaded
Open this post in threaded view
|

Re: Tests that aren't compiled in netwerk/test

polly.shaw
Thanks Ted! Sorry it's taken me so long to acknowledge your nice introduction: I was trying to write a script to uncover other unused files. (And as Boris says, the action to be taken isn't necessarily to delete them.) It gets all the contents of the moz.build (and also searches for supplementary build files included in the moz.builds) and *.gyp files, concatenates them, looks for *.cpp files in the source try and just checks to see if they're referenced in the text. So it's obviously imperfect but it is a heuristic. Here it is (run in root of the source directory)

import os
import fnmatch
import re

prog = re.compile('include[(]\'(.*)\'[)]')
   
def getMozBuildConcatenatedText(initialLocation):
    currentDir = os.path.dirname(initialLocation)
    if os.path.isfile(initialLocation):
        with open(initialLocation, 'r') as myfile:                  
            mozBuildText = myfile.read();
            for match in prog.finditer(mozBuildText):
                includedFile = match.group(1)
                if includedFile[0] != '/':
                    includedFile = currentDir + '/' + includedFile
                else:
                    includedFile = "." + includedFile
           
                mozBuildText = mozBuildText + getMozBuildConcatenatedText(includedFile)              
            return mozBuildText
    else:
        return ""


def findUnusedFiles():
    mozBuildText = ""
    for root, dirs, files in os.walk(".", ):
        if "moz.build" in files:
            mozBuildText += getMozBuildConcatenatedText(root + "/moz.build")
        for gypFile in fnmatch.filter(files, "*.gyp"):
            with open(root + "/" + gypFile, 'r') as myFile:
                mozBuildText += myFile.read()          
    for root, dirs, files in os.walk(".", ):
        for cppFile in fnmatch.filter(files, "*.cpp"):                  
            if cppFile[0:-4] not in mozBuildText:
                print "rm " + root + "/" + cppFile

findUnusedFiles()

It uncovered the 683 files beolow. When I deleted them from the build, ./mach build still ran successfully. I think some of these should be relevant, but some (such as the 7zip stuff) maybe should stay in the repo because they're from 3rd party sources which perhaps should be left intact? What do you think - maybe I should just take the plunge and put a bug on Bugzilla.

rm ./gfx/graphite2/src/GlyphFaceCache.cpp
rm ./gfx/graphite2/src/XmlTraceLog.cpp
rm ./gfx/graphite2/src/XmlTraceLogTags.cpp
rm ./gfx/thebes/gfxLanguageTagList.cpp
rm ./gfx/thebes/PrintTargetRecording.cpp
rm ./gfx/angle/src/libANGLE/validationES_unittest.cpp
rm ./gfx/angle/src/libANGLE/Image_unittest.cpp
rm ./gfx/angle/src/libANGLE/Program_unittest.cpp
rm ./gfx/angle/src/libANGLE/Config_unittest.cpp
rm ./gfx/angle/src/libANGLE/HandleRangeAllocator_unittest.cpp
rm ./gfx/angle/src/libANGLE/ImageIndexIterator_unittest.cpp
rm ./gfx/angle/src/libANGLE/ResourceManager_unittest.cpp
rm ./gfx/angle/src/libANGLE/TransformFeedback_unittest.cpp
rm ./gfx/angle/src/libANGLE/HandleAllocator_unittest.cpp
rm ./gfx/angle/src/libANGLE/BinaryStream_unittest.cpp
rm ./gfx/angle/src/libANGLE/signal_utils_unittest.cpp
rm ./gfx/angle/src/libANGLE/Surface_unittest.cpp
rm ./gfx/angle/src/libANGLE/Fence_unittest.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/glx/PbufferSurfaceGLX.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/egl/WindowSurfaceEGL.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/egl/PbufferSurfaceEGL.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/egl/FunctionsEGL.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/egl/DisplayEGL.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/egl/FunctionsEGLDL.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/egl/android/DisplayAndroid.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/egl/ozone/SurfaceOzone.cpp
rm ./gfx/angle/src/libANGLE/renderer/gl/egl/ozone/DisplayOzone.cpp
rm ./gfx/angle/src/libANGLE/renderer/d3d/d3d11/winrt/InspectableNativeWindow.cpp
rm ./gfx/angle/src/libANGLE/renderer/d3d/d3d11/winrt/CoreWindowNativeWindow_unittest.cpp
rm ./gfx/angle/src/libANGLE/renderer/d3d/d3d11/winrt/CoreWindowNativeWindow.cpp
rm ./gfx/angle/src/libANGLE/renderer/d3d/d3d11/winrt/SwapChainPanelNativeWindow_unittest.cpp
rm ./gfx/angle/src/libANGLE/renderer/d3d/d3d11/winrt/NativeWindow11WinRT.cpp
rm ./gfx/angle/src/libANGLE/renderer/d3d/d3d11/winrt/SwapChainPanelNativeWindow.cpp
rm ./gfx/angle/src/tests/deqp_support/tcuANGLENativeDisplayFactory.cpp
rm ./gfx/angle/src/tests/deqp_support/tcuANGLEPlatform.cpp
rm ./gfx/angle/src/tests/deqp_support/angle_deqp_gtest_main.cpp
rm ./gfx/angle/src/tests/deqp_support/angle_deqp_gtest.cpp
rm ./gfx/angle/src/tests/deqp_support/angle_deqp_libtester_main.cpp
rm ./gfx/angle/src/tests/deqp_support/angle_deqp_tests_main.cpp
rm ./gfx/angle/src/tests/deqp_support/tcuRandomOrderExecutor.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLContextSharingTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLSurfaceTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLSanityCheckTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLThreadTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLContextCompatibilityTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLQueryContextTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLStreamTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLRobustnessTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLX11VisualTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLDeviceTest.cpp
rm ./gfx/angle/src/tests/egl_tests/EGLPresentPathD3D11Test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/pragma_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/error_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/PreprocessorTest.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/version_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/token_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/if_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/space_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/location_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/number_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/operator_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/identifier_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/define_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/char_test.cpp
rm ./gfx/angle/src/tests/preprocessor_tests/comment_test.cpp
rm ./gfx/angle/src/tests/perf_tests/BufferSubData.cpp
rm ./gfx/angle/src/tests/perf_tests/TexSubImage.cpp
rm ./gfx/angle/src/tests/perf_tests/InstancingPerf.cpp
rm ./gfx/angle/src/tests/perf_tests/IndexDataManagerTest.cpp
rm ./gfx/angle/src/tests/perf_tests/ANGLEPerfTest.cpp
rm ./gfx/angle/src/tests/perf_tests/TextureSampling.cpp
rm ./gfx/angle/src/tests/perf_tests/UniformsPerf.cpp
rm ./gfx/angle/src/tests/perf_tests/IndexConversionPerf.cpp
rm ./gfx/angle/src/tests/perf_tests/InterleavedAttributeData.cpp
rm ./gfx/angle/src/tests/perf_tests/EGLInitializePerf.cpp
rm ./gfx/angle/src/tests/perf_tests/DrawCallPerf.cpp
rm ./gfx/angle/src/tests/perf_tests/DynamicPromotionPerfTest.cpp
rm ./gfx/angle/src/tests/perf_tests/TexturesPerf.cpp
rm ./gfx/angle/src/tests/perf_tests/PointSprites.cpp
rm ./gfx/angle/src/tests/gl_tests/BindUniformLocationTest.cpp
rm ./gfx/angle/src/tests/gl_tests/StateChangeTest.cpp
rm ./gfx/angle/src/tests/gl_tests/IncompleteTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/RobustClientMemoryTest.cpp
rm ./gfx/angle/src/tests/gl_tests/BindGeneratesResourceTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ComputeShaderTest.cpp
rm ./gfx/angle/src/tests/gl_tests/DiscardFramebufferEXTTest.cpp
rm ./gfx/angle/src/tests/gl_tests/WebGLCompatibilityTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ColorMaskTest.cpp
rm ./gfx/angle/src/tests/gl_tests/IndexBufferOffsetTest.cpp
rm ./gfx/angle/src/tests/gl_tests/UniformTest.cpp
rm ./gfx/angle/src/tests/gl_tests/DifferentStencilMasksTest.cpp
rm ./gfx/angle/src/tests/gl_tests/SRGBFramebufferTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ClearTest.cpp
rm ./gfx/angle/src/tests/gl_tests/LineLoopTest.cpp
rm ./gfx/angle/src/tests/gl_tests/MipmapTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ViewportTest.cpp
rm ./gfx/angle/src/tests/gl_tests/CopyTexImageTest.cpp
rm ./gfx/angle/src/tests/gl_tests/TransformFeedbackTest.cpp
rm ./gfx/angle/src/tests/gl_tests/D3DImageFormatConversionTest.cpp
rm ./gfx/angle/src/tests/gl_tests/D3DTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/DepthStencilFormatsTest.cpp
rm ./gfx/angle/src/tests/gl_tests/UnpackRowLength.cpp
rm ./gfx/angle/src/tests/gl_tests/D3D11EmulatedIndexedBufferTest.cpp
rm ./gfx/angle/src/tests/gl_tests/SimpleOperationTest.cpp
rm ./gfx/angle/src/tests/gl_tests/BufferDataTest.cpp
rm ./gfx/angle/src/tests/gl_tests/CubeMapTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/RendererTest.cpp
rm ./gfx/angle/src/tests/gl_tests/FramebufferTest.cpp
rm ./gfx/angle/src/tests/gl_tests/BlendMinMaxTest.cpp
rm ./gfx/angle/src/tests/gl_tests/DebugTest.cpp
rm ./gfx/angle/src/tests/gl_tests/InstancingTest.cpp
rm ./gfx/angle/src/tests/gl_tests/SixteenBppTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/MultisampleCompatibilityTest.cpp
rm ./gfx/angle/src/tests/gl_tests/IndexedPointsTest.cpp
rm ./gfx/angle/src/tests/gl_tests/DXT1CompressedTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/SwizzleTest.cpp
rm ./gfx/angle/src/tests/gl_tests/PathRenderingTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ProgramBinaryTest.cpp
rm ./gfx/angle/src/tests/gl_tests/PbufferTest.cpp
rm ./gfx/angle/src/tests/gl_tests/D3D11FormatTablesTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ProvokingVertexTest.cpp
rm ./gfx/angle/src/tests/gl_tests/GLSLTest.cpp
rm ./gfx/angle/src/tests/gl_tests/FenceSyncTests.cpp
rm ./gfx/angle/src/tests/gl_tests/SRGBTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/D3D11InputLayoutCacheTest.cpp
rm ./gfx/angle/src/tests/gl_tests/VertexAttributeTest.cpp
rm ./gfx/angle/src/tests/gl_tests/TimerQueriesTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ReadPixelsTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ETCTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/TextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ObjectAllocationTest.cpp
rm ./gfx/angle/src/tests/gl_tests/PBOExtensionTest.cpp
rm ./gfx/angle/src/tests/gl_tests/MaxTextureSizeTest.cpp
rm ./gfx/angle/src/tests/gl_tests/BlitFramebufferANGLETest.cpp
rm ./gfx/angle/src/tests/gl_tests/FramebufferMixedSamplesTest.cpp
rm ./gfx/angle/src/tests/gl_tests/UnpackAlignmentTest.cpp
rm ./gfx/angle/src/tests/gl_tests/CopyTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/DebugMarkerTest.cpp
rm ./gfx/angle/src/tests/gl_tests/ImageTest.cpp
rm ./gfx/angle/src/tests/gl_tests/CopyCompressedTextureTest.cpp
rm ./gfx/angle/src/tests/gl_tests/OcclusionQueriesTest.cpp
rm ./gfx/angle/src/tests/gl_tests/DrawBuffersTest.cpp
rm ./gfx/angle/src/tests/gl_tests/DrawElementsTest.cpp
rm ./gfx/angle/src/tests/gl_tests/PointSpritesTest.cpp
rm ./gfx/angle/src/tests/gl_tests/BuiltinVariableTest.cpp
rm ./gfx/angle/src/tests/gl_tests/FramebufferRenderMipmapTest.cpp
rm ./gfx/angle/src/tests/gl_tests/UniformBufferTest.cpp
rm ./gfx/angle/src/tests/gl_tests/SyncQueriesTest.cpp
rm ./gfx/angle/src/tests/gl_tests/PackUnpackTest.cpp
rm ./gfx/angle/src/tests/test_utils/angle_test_configs.cpp
rm ./gfx/angle/src/tests/test_utils/compiler_test.cpp
rm ./gfx/angle/src/tests/test_utils/ANGLETest.cpp
rm ./gfx/angle/src/tests/test_utils/angle_test_instantiate.cpp
rm ./gfx/angle/src/tests/compiler_tests/GLSLCompatibilityOutput_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/EXT_blend_func_extended_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/ExpressionLimit_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/DebugShaderPrecision_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/PruneEmptyDeclarations_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/TypeTracking_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/RecordConstantPrecision_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/Pack_Unpack_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/FragDepth_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/UnrollFlatten_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/QualificationOrder_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/RemovePow_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/MalformedShader_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/ShCompile_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/PruneUnusedFunctions_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/ShaderExtension_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/WorkGroupSize_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/NV_draw_buffers_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/EmulateGLFragColorBroadcast_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/CollectVariables_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/IntermNode_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/QualificationOrderESSL31_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/ConstantFolding_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/VariablePacker_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/ShaderVariable_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/ShaderImage_test.cpp
rm ./gfx/angle/src/tests/compiler_tests/API_test.cpp
rm ./gfx/angle/src/compiler/fuzz/translator_fuzzer.cpp
rm ./gfx/angle/src/common/utilities_unittest.cpp
rm ./gfx/angle/src/common/Optional_unittest.cpp
rm ./gfx/angle/src/common/string_utils_unittest.cpp
rm ./gfx/angle/src/common/matrix_utils_unittest.cpp
rm ./gfx/angle/src/common/mathutil_unittest.cpp
rm ./gfx/angle/src/common/BitSetIterator_unittest.cpp
rm ./gfx/cairo/cairo/src/cairo-qt-surface.cpp
rm ./gfx/gl/GLContextProviderNull.cpp
rm ./gfx/layers/opengl/EGLImageHelpers.cpp
rm ./gfx/2d/unittest/SanityChecks.cpp
rm ./gfx/2d/unittest/TestDrawTargetD2D.cpp
rm ./gfx/2d/unittest/TestDrawTargetBase.cpp
rm ./gfx/skia/skia/src/sksl/SkSLMain.cpp
rm ./gfx/skia/skia/src/sksl/SkSLGLSLCodeGenerator.cpp
rm ./gfx/skia/skia/src/sksl/SkSLParser.cpp
rm ./gfx/skia/skia/src/sksl/SkSLSPIRVCodeGenerator.cpp
rm ./gfx/skia/skia/src/sksl/SkSLCompiler.cpp
rm ./gfx/skia/skia/src/sksl/SkSLUtil.cpp
rm ./gfx/skia/skia/src/sksl/SkSLIRGenerator.cpp
rm ./gfx/skia/skia/src/sksl/ir/SkSLType.cpp
rm ./gfx/skia/skia/src/sksl/ir/SkSLSymbolTable.cpp
rm ./gfx/skia/skia/src/c/sk_surface.cpp
rm ./gfx/skia/skia/src/c/sk_paint.cpp
rm ./gfx/skia/skia/src/pdf/SkDocument_PDF_None.cpp
rm ./gfx/skia/skia/src/views/SkOSMenu.cpp
rm ./gfx/skia/skia/src/views/SkTagList.cpp
rm ./gfx/skia/skia/src/views/SkView.cpp
rm ./gfx/skia/skia/src/views/SkEventSink.cpp
rm ./gfx/skia/skia/src/views/SkTouchGesture.cpp
rm ./gfx/skia/skia/src/views/SkWindow.cpp
rm ./gfx/skia/skia/src/views/SkViewPriv.cpp
rm ./gfx/skia/skia/src/views/sdl/SkOSWindow_SDL.cpp
rm ./gfx/skia/skia/src/views/unix/skia_unix.cpp
rm ./gfx/skia/skia/src/views/unix/SkOSWindow_Unix.cpp
rm ./gfx/skia/skia/src/views/win/SkOSWindow_win.cpp
rm ./gfx/skia/skia/src/views/win/skia_win.cpp
rm ./gfx/skia/skia/src/android/SkBitmapRegionDecoder.cpp
rm ./gfx/skia/skia/src/android/SkBitmapRegionCodec.cpp
rm ./gfx/skia/skia/src/effects/SkLightingImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkPaintImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkOffsetImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkMatrixConvolutionImageFilter.cpp
rm ./gfx/skia/skia/src/effects/Sk1DPathEffect.cpp
rm ./gfx/skia/skia/src/effects/SkMagnifierImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkPictureImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkRRectsGaussianEdgeShader.cpp
rm ./gfx/skia/skia/src/effects/SkAlphaThresholdFilter.cpp
rm ./gfx/skia/skia/src/effects/SkBlurMaskFilter.cpp
rm ./gfx/skia/skia/src/effects/SkBlurMask.cpp
rm ./gfx/skia/skia/src/effects/SkMorphologyImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkPackBits.cpp
rm ./gfx/skia/skia/src/effects/SkTileImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkXfermodeImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkPaintFlagsDrawFilter.cpp
rm ./gfx/skia/skia/src/effects/SkLayerDrawLooper.cpp
rm ./gfx/skia/skia/src/effects/SkEmbossMask.cpp
rm ./gfx/skia/skia/src/effects/SkBlurDrawLooper.cpp
rm ./gfx/skia/skia/src/effects/SkDropShadowImageFilter.cpp
rm ./gfx/skia/skia/src/effects/Sk2DPathEffect.cpp
rm ./gfx/skia/skia/src/effects/SkGammaColorFilter.cpp
rm ./gfx/skia/skia/src/effects/SkPerlinNoiseShader.cpp
rm ./gfx/skia/skia/src/effects/SkArcToPathEffect.cpp
rm ./gfx/skia/skia/src/effects/SkComposeImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkDiscretePathEffect.cpp
rm ./gfx/skia/skia/src/effects/SkColorCubeFilter.cpp
rm ./gfx/skia/skia/src/effects/SkEmbossMaskFilter.cpp
rm ./gfx/skia/skia/src/effects/SkLumaColorFilter.cpp
rm ./gfx/skia/skia/src/effects/SkGaussianEdgeShader.cpp
rm ./gfx/skia/skia/src/effects/GrCircleBlurFragmentProcessor.cpp
rm ./gfx/skia/skia/src/effects/SkDisplacementMapEffect.cpp
rm ./gfx/skia/skia/src/effects/SkArithmeticMode_gpu.cpp
rm ./gfx/skia/skia/src/effects/SkColorFilterImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkTableColorFilter.cpp
rm ./gfx/skia/skia/src/effects/SkCornerPathEffect.cpp
rm ./gfx/skia/skia/src/effects/SkMergeImageFilter.cpp
rm ./gfx/skia/skia/src/effects/SkArithmeticMode.cpp
rm ./gfx/skia/skia/src/effects/GrAlphaThresholdFragmentProcessor.cpp
rm ./gfx/skia/skia/src/effects/SkTableMaskFilter.cpp
rm ./gfx/skia/skia/src/xps/SkDocument_XPS.cpp
rm ./gfx/skia/skia/src/xps/SkDocument_XPS_None.cpp
rm ./gfx/skia/skia/src/xps/SkXPSDevice.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_android_parser.cpp
rm ./gfx/skia/skia/src/ports/SkImageGenerator_skia.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_FontConfigInterface_factory.cpp
rm ./gfx/skia/skia/src/ports/SkImageEncoder_CG.cpp
rm ./gfx/skia/skia/src/ports/SkFontConfigInterface_direct.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_custom_directory_factory.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_FontConfigInterface.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_fontconfig.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_android.cpp
rm ./gfx/skia/skia/src/ports/SkMemory_malloc.cpp
rm ./gfx/skia/skia/src/ports/SkTLS_none.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_android_factory.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_custom_empty_factory.cpp
rm ./gfx/skia/skia/src/ports/SkImageEncoder_WIC.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_empty_factory.cpp
rm ./gfx/skia/skia/src/ports/SkImageGeneratorWIC.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_fontconfig_factory.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_custom.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_win_gdi_factory.cpp
rm ./gfx/skia/skia/src/ports/SkFontMgr_custom_embedded_factory.cpp
rm ./gfx/skia/skia/src/ports/SkImageGeneratorCG.cpp
rm ./gfx/skia/skia/src/ports/SkFontConfigInterface_direct_factory.cpp
rm ./gfx/skia/skia/src/ports/SkFontConfigInterface.cpp
rm ./gfx/skia/skia/src/core/SkRadialShadowMapShader.cpp
rm ./gfx/skia/skia/src/core/SkLightingShader.cpp
rm ./gfx/skia/skia/src/core/SkShadowShader.cpp
rm ./gfx/skia/skia/src/core/SkNormalFlatSource.cpp
rm ./gfx/skia/skia/src/core/SkLights.cpp
rm ./gfx/skia/skia/src/core/SkLiteDL.cpp
rm ./gfx/skia/skia/src/core/SkNormalBevelSource.cpp
rm ./gfx/skia/skia/src/core/SkNormalSource.cpp
rm ./gfx/skia/skia/src/core/SkLiteRecorder.cpp
rm ./gfx/skia/skia/src/core/SkNormalMapSource.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkPipeline.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkFramebuffer.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkVaryingHandler.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkImageView.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkCopyPipeline.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkSampler.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkUniformHandler.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkPipelineStateBuilder.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkTextureRenderTarget.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkTransferBuffer.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkInterface.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkCaps.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkPipelineStateDataManager.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkPipelineState.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkBuffer.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkDescriptorSet.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkDescriptorSetManager.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkUtil.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkStencilAttachment.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkVertexBuffer.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkUniformBuffer.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkPipelineStateCache.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkMemory.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkResourceProvider.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkCopyManager.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkGpuCommandBuffer.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkGpu.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkRenderTarget.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkRenderPass.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkCommandBuffer.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkImage.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkBackendContext.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkIndexBuffer.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkTexture.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkExtensions.cpp
rm ./gfx/skia/skia/src/gpu/vk/GrVkDescriptorPool.cpp
rm ./gfx/skia/skia/src/gpu/gl/GrGLTestInterface.cpp
rm ./gfx/skia/skia/src/gpu/gl/GrGLDefaultInterface_none.cpp
rm ./gfx/skia/skia/src/gpu/gl/GrGLCreateNullInterface.cpp
rm ./gfx/skia/skia/src/gpu/gl/GrGLAssembleInterface.cpp
rm ./gfx/skia/skia/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp
rm ./gfx/skia/skia/src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp
rm ./gfx/skia/skia/src/gpu/gl/glx/GrGLCreateNativeInterface_glx.cpp
rm ./gfx/skia/skia/src/gpu/gl/egl/GrGLCreateNativeInterface_egl.cpp
rm ./gfx/skia/skia/src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp
rm ./gfx/skia/skia/src/gpu/gl/glfw/GrGLCreateNativeInterface_glfw.cpp
rm ./gfx/skia/skia/src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp
rm ./gfx/skia/skia/src/svg/SkSVGCanvas.cpp
rm ./gfx/skia/skia/src/svg/SkSVGDevice.cpp
rm ./gfx/skia/skia/src/utils/SkCamera.cpp
rm ./gfx/skia/skia/src/utils/SkPaintFilterCanvas.cpp
rm ./gfx/skia/skia/src/utils/SkBoundaryPatch.cpp
rm ./gfx/skia/skia/src/utils/SkNullCanvas.cpp
rm ./gfx/skia/skia/src/utils/SkParseColor.cpp
rm ./gfx/skia/skia/src/utils/SkMeshUtils.cpp
rm ./gfx/skia/skia/src/utils/SkLuaCanvas.cpp
rm ./gfx/skia/skia/src/utils/SkLua.cpp
rm ./gfx/skia/skia/src/utils/SkShadowPaintFilterCanvas.cpp
rm ./gfx/skia/skia/src/utils/SkWhitelistTypefaces.cpp
rm ./gfx/skia/skia/src/utils/SkTextBox.cpp
rm ./gfx/skia/skia/src/utils/SkInterpolator.cpp
rm ./gfx/skia/skia/src/utils/SkDeferredCanvas.cpp
rm ./gfx/skia/skia/src/utils/SkDumpCanvas.cpp
rm ./gfx/skia/skia/src/utils/SkFrontBufferedStream.cpp
rm ./gfx/skia/skia/src/utils/SkCanvasStateUtils.cpp
rm ./gfx/skia/skia/src/utils/SkMultiPictureDocumentReader.cpp
rm ./gfx/skia/skia/src/utils/SkPatchGrid.cpp
rm ./gfx/skia/skia/src/utils/SkCanvasStack.cpp
rm ./gfx/skia/skia/src/utils/SkCurveMeasure.cpp
rm ./gfx/skia/skia/src/utils/SkMultiPictureDocument.cpp
rm ./gfx/skia/skia/src/utils/SkNWayCanvas.cpp
rm ./gfx/skia/skia/src/utils/win/SkWGL_win.cpp
rm ./gfx/skia/skia/src/fonts/SkGScalerContext.cpp
rm ./gfx/skia/skia/src/fonts/SkRandomScalerContext.cpp
rm ./gfx/skia/skia/src/fonts/SkTestScalerContext.cpp
rm ./gfx/skia/skia/src/codec/SkSwizzler.cpp
rm ./gfx/skia/skia/src/codec/SkJpegUtility.cpp
rm ./gfx/skia/skia/src/codec/SkAndroidCodec.cpp
rm ./gfx/skia/skia/src/codec/SkRawCodec.cpp
rm ./gfx/skia/skia/src/codec/SkWebpAdapterCodec.cpp
rm ./gfx/skia/skia/src/codec/SkCodecImageGenerator.cpp
rm ./gfx/skia/skia/src/codec/SkCodec.cpp
rm ./gfx/skia/skia/src/codec/SkJpegCodec.cpp
rm ./gfx/skia/skia/src/codec/SkBmpCodec.cpp
rm ./gfx/skia/skia/src/codec/SkPngCodec.cpp
rm ./gfx/skia/skia/src/codec/SkRawAdapterCodec.cpp
rm ./gfx/skia/skia/src/codec/SkWebpCodec.cpp
rm ./gfx/skia/skia/src/codec/SkWbmpCodec.cpp
rm ./gfx/skia/skia/src/codec/SkSampler.cpp
rm ./gfx/skia/skia/src/codec/SkSampledCodec.cpp
rm ./gfx/skia/skia/src/codec/SkMasks.cpp
rm ./gfx/skia/skia/src/codec/SkGifCodec.cpp
rm ./gfx/skia/skia/src/codec/SkIcoCodec.cpp
rm ./gfx/skia/skia/src/codec/SkBmpMaskCodec.cpp
rm ./gfx/skia/skia/src/codec/SkBmpStandardCodec.cpp
rm ./gfx/skia/skia/src/codec/SkBmpRLECodec.cpp
rm ./gfx/skia/skia/src/codec/SkMaskSwizzler.cpp
rm ./gfx/skia/skia/src/codec/SkJpegDecoderMgr.cpp
rm ./gfx/skia/skia/src/animator/SkScriptTokenizer.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayApply.cpp
rm ./gfx/skia/skia/src/animator/SkAnimateMaker.cpp
rm ./gfx/skia/skia/src/animator/SkDrawMatrix.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayable.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayTypes.cpp
rm ./gfx/skia/skia/src/animator/SkAnimatorScript.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayList.cpp
rm ./gfx/skia/skia/src/animator/SkDrawBitmap.cpp
rm ./gfx/skia/skia/src/animator/SkBoundable.cpp
rm ./gfx/skia/skia/src/animator/SkDrawRectangle.cpp
rm ./gfx/skia/skia/src/animator/SkDrawGroup.cpp
rm ./gfx/skia/skia/src/animator/SkHitClear.cpp
rm ./gfx/skia/skia/src/animator/SkGetCondensedInfo.cpp
rm ./gfx/skia/skia/src/animator/SkXMLAnimatorWriter.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayBounds.cpp
rm ./gfx/skia/skia/src/animator/SkHitTest.cpp
rm ./gfx/skia/skia/src/animator/SkADrawable.cpp
rm ./gfx/skia/skia/src/animator/SkDrawTo.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayInclude.cpp
rm ./gfx/skia/skia/src/animator/SkMemberInfo.cpp
rm ./gfx/skia/skia/src/animator/SkDrawPath.cpp
rm ./gfx/skia/skia/src/animator/SkDrawFull.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayRandom.cpp
rm ./gfx/skia/skia/src/animator/SkOpArray.cpp
rm ./gfx/skia/skia/src/animator/SkPaintPart.cpp
rm ./gfx/skia/skia/src/animator/SkDrawExtraPathEffect.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayType.cpp
rm ./gfx/skia/skia/src/animator/SkDrawDiscrete.cpp
rm ./gfx/skia/skia/src/animator/SkTextOnPath.cpp
rm ./gfx/skia/skia/src/animator/SkAnimateField.cpp
rm ./gfx/skia/skia/src/animator/SkDrawSaveLayer.cpp
rm ./gfx/skia/skia/src/animator/SkParseSVGPath.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayScreenplay.cpp
rm ./gfx/skia/skia/src/animator/SkDrawColor.cpp
rm ./gfx/skia/skia/src/animator/SkDrawDash.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayInput.cpp
rm ./gfx/skia/skia/src/animator/SkDrawLine.cpp
rm ./gfx/skia/skia/src/animator/SkSnapshot.cpp
rm ./gfx/skia/skia/src/animator/SkScriptDecompile.cpp
rm ./gfx/skia/skia/src/animator/SkPathParts.cpp
rm ./gfx/skia/skia/src/animator/SkScript.cpp
rm ./gfx/skia/skia/src/animator/SkAnimateBase.cpp
rm ./gfx/skia/skia/src/animator/SkDrawClip.cpp
rm ./gfx/skia/skia/src/animator/SkDrawOval.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayXMLParser.cpp
rm ./gfx/skia/skia/src/animator/SkTextToPath.cpp
rm ./gfx/skia/skia/src/animator/SkScriptRuntime.cpp
rm ./gfx/skia/skia/src/animator/SkAnimateActive.cpp
rm ./gfx/skia/skia/src/animator/SkMatrixParts.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayMath.cpp
rm ./gfx/skia/skia/src/animator/SkAnimatorScript2.cpp
rm ./gfx/skia/skia/src/animator/SkDrawTextBox.cpp
rm ./gfx/skia/skia/src/animator/SkOperandIterpolator.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayPost.cpp
rm ./gfx/skia/skia/src/animator/SkDrawText.cpp
rm ./gfx/skia/skia/src/animator/SkPostParts.cpp
rm ./gfx/skia/skia/src/animator/SkDrawBlur.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayEvent.cpp
rm ./gfx/skia/skia/src/animator/SkDrawEmboss.cpp
rm ./gfx/skia/skia/src/animator/SkDrawGradient.cpp
rm ./gfx/skia/skia/src/animator/SkAnimateSet.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayNumber.cpp
rm ./gfx/skia/skia/src/animator/SkDrawPoint.cpp
rm ./gfx/skia/skia/src/animator/SkTypedArray.cpp
rm ./gfx/skia/skia/src/animator/SkDump.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayAdd.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayEvents.cpp
rm ./gfx/skia/skia/src/animator/SkDraw3D.cpp
rm ./gfx/skia/skia/src/animator/SkAnimator.cpp
rm ./gfx/skia/skia/src/animator/SkDrawPaint.cpp
rm ./gfx/skia/skia/src/animator/SkDrawShader.cpp
rm ./gfx/skia/skia/src/animator/SkBuildCondensedInfo.cpp
rm ./gfx/skia/skia/src/animator/SkDisplayMovie.cpp
rm ./gfx/skia/skia/src/xml/SkXMLWriter.cpp
rm ./gfx/skia/skia/src/xml/SkXMLParser.cpp
rm ./gfx/skia/skia/src/xml/SkDOM.cpp
rm ./gfx/skia/skia/src/images/SkForceLinking.cpp
rm ./gfx/skia/skia/src/images/SkWEBPImageEncoder.cpp
rm ./gfx/skia/skia/src/images/SkMovie_FactoryDefault.cpp
rm ./gfx/skia/skia/src/images/SkJPEGWriteUtility.cpp
rm ./gfx/skia/skia/src/images/SkPNGImageEncoder.cpp
rm ./gfx/skia/skia/src/images/SkGIFMovie.cpp
rm ./gfx/skia/skia/src/images/SkJPEGImageEncoder.cpp
rm ./gfx/skia/skia/src/images/SkKTXImageEncoder.cpp
rm ./gfx/skia/skia/src/images/SkImageEncoder_Factory.cpp
rm ./gfx/skia/skia/src/images/SkMovie.cpp
rm ./gfx/skia/skia/src/opts/SkBlitRow_opts_mips_dsp.cpp
rm ./gfx/skia/skia/src/opts/SkBitmapProcState_opts_mips_dsp.cpp
rm ./gfx/skia/skia/src/opts/SkOpts_crc32.cpp
rm ./ipc/ipdl/test/cxx/IPDLUnitTests.template.cpp
rm ./editor/txtsvc/nsTextServicesFactory.cpp
rm ./js/src/devtools/vprof/vprof.cpp
rm ./js/src/devtools/gctrace/gcstats.cpp
rm ./js/src/jsapi-tests/testValueABI.cpp
rm ./js/src/jsapi-tests/testSlowScript.cpp
rm ./nsprpub/pr/src/cplus/rcthread.cpp
rm ./nsprpub/pr/src/cplus/rcnetdb.cpp
rm ./nsprpub/pr/src/cplus/rcfileio.cpp
rm ./nsprpub/pr/src/cplus/rclock.cpp
rm ./nsprpub/pr/src/cplus/rcinrval.cpp
rm ./nsprpub/pr/src/cplus/rccv.cpp
rm ./nsprpub/pr/src/cplus/rcio.cpp
rm ./nsprpub/pr/src/cplus/rctime.cpp
rm ./nsprpub/pr/src/cplus/rcbase.cpp
rm ./nsprpub/pr/src/cplus/rcnetio.cpp
rm ./nsprpub/pr/src/cplus/tests/fileio.cpp
rm ./nsprpub/pr/src/cplus/tests/ranfile.cpp
rm ./nsprpub/lib/prstreams/prstrms.cpp
rm ./nsprpub/lib/prstreams/tests/testprstrm/testprstrm.cpp
rm ./toolkit/xre/nsWindowsWMain.cpp
rm ./toolkit/crashreporter/google-breakpad/android/sample_app/jni/test_breakpad.cpp
rm ./python/which/launcher.cpp
rm ./widget/gonk/libui/InputManager.cpp
rm ./widget/tests/TestAppShellSteadyState.cpp
rm ./widget/windows/tests/TestWinDND.cpp
rm ./netwerk/protocol/data/nsDataModule.cpp
rm ./netwerk/test/TestSocketInput.cpp
rm ./netwerk/test/TestFileInput2.cpp
rm ./netwerk/test/TestSocketIO.cpp
rm ./netwerk/test/TestDNSDaemon.cpp
rm ./netwerk/test/TestMakeAbs.cpp
rm ./netwerk/test/TestCacheBlockFiles.cpp
rm ./netwerk/test/TestCachePrefixKeyParser.cpp
rm ./netwerk/test/TestOverlappedIO.cpp
rm ./netwerk/test/TestWriteSpeed.cpp
rm ./third_party/rust/libz-sys/src/zlib-1.2.8/contrib/iostream/zfstream.cpp
rm ./third_party/rust/libz-sys/src/zlib-1.2.8/contrib/iostream2/zstream_test.cpp
rm ./uriloader/exthandler/mac/nsDecodeAppleFile.cpp
rm ./dom/canvas/WebGLContextNotSupported.cpp
rm ./dom/system/gonk/mozstumbler/MozStumbler.cpp
rm ./dom/system/gonk/mozstumbler/UploadStumbleRunnable.cpp
rm ./dom/system/gonk/mozstumbler/WriteStumbleOnThread.cpp
rm ./dom/system/gonk/mozstumbler/StumblerLogging.cpp
rm ./dom/media/gtest/TestTimeUnit.cpp
rm ./dom/media/webaudio/blink/IRC_Composite_C_R0195-incl.cpp
rm ./tools/fuzzing/libfuzzer/FuzzerMain.cpp
rm ./memory/jemalloc/src/msvc/projects/vc2015/test_threads/test_threads_main.cpp
rm ./memory/jemalloc/src/msvc/projects/vc2015/test_threads/test_threads.cpp
rm ./other-licenses/nsis/Contrib/CertCheck/CertCheck.cpp
rm ./other-licenses/nsis/Contrib/liteFirewall/liteFirewall.cpp
rm ./other-licenses/nsis/Contrib/CityHash/CityHash.cpp
rm ./other-licenses/nsis/Contrib/InetBgDL/InetBgDL.cpp
rm ./other-licenses/nsis/Contrib/ExDLL/exdllutil.cpp
rm ./other-licenses/7zstub/src/7zip/Bundles/SFXSetup-moz/ExtractEngine.cpp
rm ./other-licenses/7zstub/src/7zip/Bundles/SFXSetup-moz/ExtractCallback.cpp
rm ./other-licenses/7zstub/src/7zip/Bundles/SFXSetup-moz/StdAfx.cpp
rm ./other-licenses/7zstub/src/7zip/UI/GUI/OpenCallbackGUI.cpp
rm ./other-licenses/7zstub/src/7zip/UI/Explorer/MyMessages.cpp
rm ./other-licenses/7zstub/src/7zip/UI/Common/ArchiverInfo.cpp
rm ./other-licenses/7zstub/src/7zip/UI/Common/DefaultName.cpp
rm ./other-licenses/7zstub/src/7zip/UI/Common/ArchiveOpenCallback.cpp
rm ./other-licenses/7zstub/src/7zip/UI/Common/OpenArchive.cpp
rm ./other-licenses/7zstub/src/7zip/FileManager/FormatUtils.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zCompressionMode.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zProperties.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zIn.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zHeader.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zDecode.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zFolderOutStream.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zHandler.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zMethodID.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zExtract.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/7z/7zMethods.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/Common/ItemNameUtils.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/Common/OutStreamWithCRC.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/Common/FilterCoder.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/Common/CoderMixer2MT.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/Common/CoderMixer2.cpp
rm ./other-licenses/7zstub/src/7zip/Archive/Common/CrossThreadProgress.cpp
rm ./other-licenses/7zstub/src/7zip/Compress/Branch/x86_2.cpp
rm ./other-licenses/7zstub/src/7zip/Compress/Branch/BranchCoder.cpp
rm ./other-licenses/7zstub/src/7zip/Compress/Copy/CopyCoder.cpp
rm ./other-licenses/7zstub/src/7zip/Compress/LZMA/LZMADecoder.cpp
rm ./other-licenses/7zstub/src/7zip/Compress/RangeCoder/RangeCoderBit.cpp
rm ./other-licenses/7zstub/src/7zip/Compress/LZ/LZOutWindow.cpp
rm ./other-licenses/7zstub/src/7zip/Common/LockedStream.cpp
rm ./other-licenses/7zstub/src/7zip/Common/ProgressUtils.cpp
rm ./other-licenses/7zstub/src/7zip/Common/InOutTempBuffer.cpp
rm ./other-licenses/7zstub/src/7zip/Common/LSBFEncoder.cpp
rm ./other-licenses/7zstub/src/7zip/Common/OutBuffer.cpp
rm ./other-licenses/7zstub/src/7zip/Common/InBuffer.cpp
rm ./other-licenses/7zstub/src/7zip/Common/StreamObjects.cpp
rm ./other-licenses/7zstub/src/7zip/Common/LimitedStreams.cpp
rm ./other-licenses/7zstub/src/7zip/Common/OffsetStream.cpp
rm ./other-licenses/7zstub/src/7zip/Common/StreamBinder.cpp
rm ./other-licenses/7zstub/src/7zip/Common/LSBFDecoder.cpp
rm ./other-licenses/7zstub/src/7zip/Common/FilePathAutoRename.cpp
rm ./other-licenses/7zstub/src/Windows/ResourceString.cpp
rm ./other-licenses/7zstub/src/Windows/PropVariant.cpp
rm ./other-licenses/7zstub/src/Windows/PropVariantConversions.cpp
rm ./other-licenses/7zstub/src/Windows/FileDir.cpp
rm ./other-licenses/7zstub/src/Common/NewHandler.cpp
rm ./other-licenses/7zstub/src/Common/StringConvert.cpp
rm ./other-licenses/7zstub/src/Common/UTFConvert.cpp
rm ./other-licenses/7zstub/src/Common/CommandLineParser.cpp
rm ./other-licenses/7zstub/src/Common/StdInStream.cpp
rm ./other-licenses/7zstub/src/Common/Wildcard.cpp
rm ./other-licenses/7zstub/src/Common/StdOutStream.cpp
rm ./other-licenses/7zstub/src/Common/MyWindows.cpp
rm ./other-licenses/7zstub/src/Common/TextConfig.cpp
rm ./other-licenses/7zstub/src/Common/IntToString.cpp
rm ./intl/unicharutil/util/nsUnicodePropertyData.cpp
rm ./intl/chardet/tools/GenCyrillicClass.cpp
rm ./intl/uconv/tests/nsTestUConv.cpp
rm ./intl/icu/source/extra/scrptrun/srtest.cpp
rm ./intl/icu/source/extra/scrptrun/scrptrun.cpp
rm ./intl/icu/source/io/ucln_io.cpp
rm ./intl/icu/source/io/uprintf.cpp
rm ./intl/icu/source/io/locbund.cpp
rm ./intl/icu/source/io/ustream.cpp
rm ./intl/icu/source/tools/gendict/gendict.cpp
rm ./intl/icu/source/tools/tzcode/tz2icu.cpp
rm ./intl/icu/source/tools/tzcode/icuzdump.cpp
rm ./intl/icu/source/tools/ctestfw/tstdtmod.cpp
rm ./intl/icu/source/tools/ctestfw/datamap.cpp
rm ./intl/icu/source/tools/ctestfw/testdata.cpp
rm ./intl/icu/source/tools/makeconv/genmbcs.cpp
rm ./intl/icu/source/tools/makeconv/makeconv.cpp
rm ./intl/icu/source/tools/gennorm2/n2builder.cpp
rm ./intl/icu/source/tools/gennorm2/gennorm2.cpp
rm ./intl/icu/source/tools/icuinfo/icuinfo.cpp
rm ./intl/icu/source/tools/genrb/wrtjava.cpp
rm ./intl/icu/source/tools/genrb/prscmnts.cpp
rm ./intl/icu/source/tools/genrb/reslist.cpp
rm ./intl/icu/source/tools/genrb/wrtxml.cpp
rm ./intl/icu/source/tools/genrb/genrb.cpp
rm ./intl/icu/source/tools/icuswap/icuswap.cpp
rm ./intl/icu/source/tools/gencolusb/verify_uset.cpp
rm ./intl/icu/source/tools/gencolusb/extract_unsafe_backwards.cpp
rm ./intl/icu/source/tools/icupkg/icupkg.cpp
rm ./intl/icu/source/tools/genbrk/genbrk.cpp
rm ./intl/icu/source/tools/toolutil/ppucd.cpp
rm ./intl/icu/source/tools/toolutil/pkgitems.cpp
rm ./intl/icu/source/tools/toolutil/xmlparser.cpp
rm ./intl/icu/source/tools/toolutil/pkg_icu.cpp
rm ./intl/icu/source/tools/toolutil/denseranges.cpp
rm ./intl/icu/source/tools/toolutil/swapimpl.cpp
rm ./intl/icu/source/tools/toolutil/udbgutil.cpp
rm ./intl/icu/source/tools/toolutil/toolutil.cpp
rm ./intl/icu/source/tools/toolutil/filetools.cpp
rm ./intl/icu/source/tools/toolutil/collationinfo.cpp
rm ./intl/icu/source/tools/toolutil/ucln_tu.cpp
rm ./intl/icu/source/tools/toolutil/dbgutil.cpp
rm ./intl/icu/source/tools/toolutil/ucbuf.cpp
rm ./intl/icu/source/tools/gencfu/gencfu.cpp
rm ./intl/icu/source/tools/pkgdata/pkgdata.cpp
rm ./build/clang-plugin/MozillaTidyModule.cpp
rm ./build/pymake/tests/pathdir/src/pathtest.cpp
rm ./xpcom/tests/TestingAtoms.cpp
rm ./xpcom/tests/SizeTest06.cpp
rm ./xpcom/tests/TestStreamUtils.cpp
rm ./xpcom/tests/SizeTest04.cpp
rm ./xpcom/tests/RegFactory.cpp
rm ./xpcom/tests/SizeTest05.cpp
rm ./xpcom/tests/SizeTest02.cpp
rm ./xpcom/tests/MoreTestingAtoms.cpp
rm ./xpcom/tests/SizeTest01.cpp
rm ./xpcom/tests/TestStackCrawl.cpp
rm ./xpcom/tests/SizeTest03.cpp
rm ./xpcom/tests/windows/TestHelloXPLoop.cpp
rm ./xpcom/tests/windows/TestNTFSPermissions.cpp
rm ./xpcom/tests/windows/TestWinFileAttribs.cpp
rm ./xpcom/reflect/xptcall/md/unix/vtable_layout_x86.cpp
rm ./xpcom/reflect/xptcall/md/unix/xptcinvoke_ppc_rhapsody.cpp
rm ./xpcom/reflect/xptcall/md/unix/xptcstubs_ppc_rhapsody.cpp
rm ./xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_darwin.cpp
rm ./xpcom/reflect/xptcall/md/test/invoke_test.cpp
rm ./xpcom/string/nsTStringComparator.cpp
rm ./xpcom/string/nsTStringObsolete.cpp
rm ./media/webrtc/signaling/gtest/mediaconduit_unittests.cpp
rm ./media/webrtc/signaling/test/mediapipeline_unittest.cpp
rm ./media/webrtc/signaling/test/FakeIPC.cpp
rm ./media/webrtc/signaling/test/signaling_unittests.cpp
rm ./media/webrtc/signaling/src/media-conduit/CodecStatistics.cpp
rm ./media/webrtc/signaling/src/media/CSFAudioControlWrapper.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/ChromeClassTester.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/FindBadConstructs.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/tests/inline_ctor.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/tests/missing_ctor.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/tests/inline_copy_ctor.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/tests/virtual_methods.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/tests/base_refcounted.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/tests/nested_class_inline_ctor.cpp
rm ./media/webrtc/trunk/tools/clang/plugins/tests/overridden_methods.cpp
rm ./media/libcubeb/gtest/test_ring_array.cpp
rm ./media/libcubeb/gtest/test_devices.cpp
_______________________________________________
dev-builds mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-builds

Reply | Threaded
Open this post in threaded view
|

Re: Tests that aren't compiled in netwerk/test

Ted Mielczarek-2
On Tue, Jan 10, 2017, at 08:27 AM, [hidden email] wrote:
> Thanks Ted! Sorry it's taken me so long to acknowledge your nice
> introduction: I was trying to write a script to uncover other unused
> files. (And as Boris says, the action to be taken isn't necessarily to
> delete them.) It gets all the contents of the moz.build (and also
> searches for supplementary build files included in the moz.builds) and
> *.gyp files, concatenates them, looks for *.cpp files in the source try
> and just checks to see if they're referenced in the text. So it's
> obviously imperfect but it is a heuristic. Here it is (run in root of the
> source directory)

No worries, I have a million other things going on, and I also often
take forever to reply to emails!

<snipped>

> It uncovered the 683 files beolow. When I deleted them from the build,
> ./mach build still ran successfully. I think some of these should be
> relevant, but some (such as the 7zip stuff) maybe should stay in the repo
> because they're from 3rd party sources which perhaps should be left
> intact? What do you think - maybe I should just take the plunge and put a
> bug on Bugzilla.

So you're right, a lot of these are definitely from third-party sources
where we import code from elsewhere wholesale--at a glance: angle,
cairo, skia, google-breakpad, nsprpub, jemalloc, everything under
other-licenses, icu, and webrtc/trunk are all third-party code.
Unfortunately we don't have a good list of these directories that you
could use to filter your results. We have a couple of ad-hoc lists
laying around, like this one in our in-tree clang plugin of directories
to skip while running our custom static analyses:
https://dxr.mozilla.org/mozilla-central/rev/7011ed1427de2b6f075c46cc6f4618d3e9fcd2a4/build/clang-plugin/Utils.h#178

and this list of directories I cobbled together in a set of scripts that
generate stats on the number of Makefiles we have in the source tree:
https://gist.github.com/luser/8a99b1accd2b96a37f7e#file-makefilestats-py-L17

There are plenty of valid hits in that list though (nice work!), and
it'd be great to get bugs on file for either building those source files
or removing them. The best course of action in situations like this is
usually to file a bug per-component. It's not 100%, but we do have
metadata in many moz.build files about what bugzilla component to use,
and a mach command you can use to query it, like:
$ ./mach file-info bugzilla-component
xpcom/string/nsTStringComparator.cpp
Core :: String
  xpcom/string/nsTStringComparator.cpp

bz is right in that it might be nice to actually build some of these,
especially if they're tests, but I don't hold out a lot of hope that
source files that have not been building in our CI for a long time will
actually build successfully. You can certainly test that theory if
you're interested! If you don't already have access to our try server
it's easy enough to get[1][2] (and I'd be happy to vouch for your
access).

Good luck!
-Ted

1.
https://www.mozilla.org/en-US/about/governance/policies/commit/access-policy/
2. https://www.mozilla.org/en-US/about/governance/policies/commit/
_______________________________________________
dev-builds mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-builds
Reply | Threaded
Open this post in threaded view
|

Re: Tests that aren't compiled in netwerk/test

Nicholas Nethercote
tools/rewriting/ThirdPartyPaths.txt in the repo is another list of third-party code.

Nick

On Wed, Jan 11, 2017 at 4:53 AM, Ted Mielczarek <[hidden email]> wrote:
On Tue, Jan 10, 2017, at 08:27 AM, [hidden email] wrote:
> Thanks Ted! Sorry it's taken me so long to acknowledge your nice
> introduction: I was trying to write a script to uncover other unused
> files. (And as Boris says, the action to be taken isn't necessarily to
> delete them.) It gets all the contents of the moz.build (and also
> searches for supplementary build files included in the moz.builds) and
> *.gyp files, concatenates them, looks for *.cpp files in the source try
> and just checks to see if they're referenced in the text. So it's
> obviously imperfect but it is a heuristic. Here it is (run in root of the
> source directory)

No worries, I have a million other things going on, and I also often
take forever to reply to emails!

<snipped>

> It uncovered the 683 files beolow. When I deleted them from the build,
> ./mach build still ran successfully. I think some of these should be
> relevant, but some (such as the 7zip stuff) maybe should stay in the repo
> because they're from 3rd party sources which perhaps should be left
> intact? What do you think - maybe I should just take the plunge and put a
> bug on Bugzilla.

So you're right, a lot of these are definitely from third-party sources
where we import code from elsewhere wholesale--at a glance: angle,
cairo, skia, google-breakpad, nsprpub, jemalloc, everything under
other-licenses, icu, and webrtc/trunk are all third-party code.
Unfortunately we don't have a good list of these directories that you
could use to filter your results. We have a couple of ad-hoc lists
laying around, like this one in our in-tree clang plugin of directories
to skip while running our custom static analyses:
https://dxr.mozilla.org/mozilla-central/rev/7011ed1427de2b6f075c46cc6f4618d3e9fcd2a4/build/clang-plugin/Utils.h#178

and this list of directories I cobbled together in a set of scripts that
generate stats on the number of Makefiles we have in the source tree:
https://gist.github.com/luser/8a99b1accd2b96a37f7e#file-makefilestats-py-L17

There are plenty of valid hits in that list though (nice work!), and
it'd be great to get bugs on file for either building those source files
or removing them. The best course of action in situations like this is
usually to file a bug per-component. It's not 100%, but we do have
metadata in many moz.build files about what bugzilla component to use,
and a mach command you can use to query it, like:
$ ./mach file-info bugzilla-component
xpcom/string/nsTStringComparator.cpp
Core :: String
  xpcom/string/nsTStringComparator.cpp

bz is right in that it might be nice to actually build some of these,
especially if they're tests, but I don't hold out a lot of hope that
source files that have not been building in our CI for a long time will
actually build successfully. You can certainly test that theory if
you're interested! If you don't already have access to our try server
it's easy enough to get[1][2] (and I'd be happy to vouch for your
access).

Good luck!
-Ted

1.
https://www.mozilla.org/en-US/about/governance/policies/commit/access-policy/
2. https://www.mozilla.org/en-US/about/governance/policies/commit/
_______________________________________________
dev-builds mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-builds


_______________________________________________
dev-builds mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-builds
Reply | Threaded
Open this post in threaded view
|

Re: Tests that aren't compiled in netwerk/test

Ted Mielczarek-2
On Tue, Jan 10, 2017, at 03:38 PM, Nicholas Nethercote wrote:
tools/rewriting/ThirdPartyPaths.txt in the repo is another list of third-party code.
Nick

Thanks! I knew we had a more comprehensive list somewhere but I could not remember where.

-Ted



_______________________________________________
dev-builds mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-builds