Table and fieldset min-widths

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Table and fieldset min-widths

Boris Zbarsky
David, I've gone ahead and added some code to not allow tables to shrink below
their intrinsic min width, by munging mComputedMinWidth in
nsHTMLReflowState::ComputeMinMaxValues.  The checkin is
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=REFLOW_20060302_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-04-28+13%3A15&maxdate=2006-04-28+13%3A17&cvsroot=%2Fcvsroot 
if you want to give it a once-over.

-Boris
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout
Reply | Threaded
Open this post in threaded view
|

Re: Table and fieldset min-widths

L. David Baron
On Friday 2006-04-28 15:18 -0500, Boris Zbarsky wrote:
> David, I've gone ahead and added some code to not allow tables to shrink
> below their intrinsic min width, by munging mComputedMinWidth in
> nsHTMLReflowState::ComputeMinMaxValues.  The checkin is
> http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=REFLOW_20060302_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-04-28+13%3A15&maxdate=2006-04-28+13%3A17&cvsroot=%2Fcvsroot 
> if you want to give it a once-over.

Seems reasonable, although I'm not sure if the interaction with
'min-width' and 'max-width' is what we want.

I was thinking about moving more of this into the frame classes, though.

-David

--
L. David Baron                                <URL: http://dbaron.org/ >
           Technical Lead, Layout & CSS, Mozilla Corporation

_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Table and fieldset min-widths

Boris Zbarsky
In reply to this post by Boris Zbarsky
L. David Baron wrote:
> Seems reasonable, although I'm not sure if the interaction with
> 'min-width' and 'max-width' is what we want.

It looked right in my testing... where "right" is "what we do before
reflow branch".

> I was thinking about moving more of this into the frame classes, though.

Hmm... we could add  a "width override" method.  In fact, if we're going
to have nsLayoutUtils::IntrinsicForContainer produce results consistent
with the nsHTMLReflowState code, we either need that or to add checks
for these two frame types there and do similar magic.

-Boris
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout