String changes in Lightning's calendar-extract.properties file

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

String changes in Lightning's calendar-extract.properties file

Merike Sell
Hi all,

Bug 1154448 changed placeholder format used in
calendar-extract.properties file. This is a technical change not
affecting the meaning of patterns so the keys were not changed and
dashboard won't notify you about it. The change does, however, require
all locales to replace old placeholders with new ones so that Lightning
could still provide users with automatically set dates and times when
they convert an email to an event.

Three replacements needed in calendar-extract.properties are as follows:
%1$S -> #1
%2$S -> #2
%3$S -> #3

If you work on files directly you can use your preferred text editor to
make these replacements across the file. This only applies if you work
on central or aurora as this change hasn't reached beta yet.

If you cannot or don't want to make the changes yourself we can probably
find a way to make them for you. Please let me know if you'd like to
have it changed for your locale. (any of this list, email or irc will do)

Merike
_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Michal Stanke
Hi Merike.

Thank you for your notification. I have made those three replacements in
https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/a193de74f77b.
Can you please check the replacement has been done properly?

Cheers,
Michal Stanke

Dne 16.12.2015 v 22:30 Merike Sell napsal(a):

> Hi all,
>
> Bug 1154448 changed placeholder format used in
> calendar-extract.properties file. This is a technical change not
> affecting the meaning of patterns so the keys were not changed and
> dashboard won't notify you about it. The change does, however, require
> all locales to replace old placeholders with new ones so that Lightning
> could still provide users with automatically set dates and times when
> they convert an email to an event.
>
> Three replacements needed in calendar-extract.properties are as follows:
> %1$S -> #1
> %2$S -> #2
> %3$S -> #3
>
> If you work on files directly you can use your preferred text editor to
> make these replacements across the file. This only applies if you work
> on central or aurora as this change hasn't reached beta yet.
>
> If you cannot or don't want to make the changes yourself we can probably
> find a way to make them for you. Please let me know if you'd like to
> have it changed for your locale. (any of this list, email or irc will do)
>
> Merike
> _______________________________________________
> dev-l10n mailing list
> [hidden email]
> https://lists.mozilla.org/listinfo/dev-l10n

_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Merike Sell
In reply to this post by Merike Sell
Hi!

Cs looks fine. Thanks!

For anyone else curious I've started a spreadsheet [1] to track progress
so far and requests for help. (this is for me, you don't need to do
anything additional)

Merike

[1]
https://docs.google.com/spreadsheets/d/1wIcoysgN0lI-2hdutjzHNGyCLjKpv2er6OjHtPHf2O8

17.12.2015 09:07 Michal Stanke kirjutas:
> Hi Merike.
>
> Thank you for your notification. I have made those three replacements in
> https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/a193de74f77b.
> Can you please check the replacement has been done properly?
>
> Cheers,
> Michal Stanke

_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file (warning to Pootle locales)

Merike Sell
In reply to this post by Merike Sell
For reasons I've been unable to find out on 24th December there were a
number of commits from Pootle to different locale repositories that
removed all/some previously translated patterns containing placeholders.
If your locale is affected you may not have seen strings using old
placeholders showing up on Pootle at all and were unable to apply
updates. Instead the patterns would be untranslated.

Having none or very few patterns with updated placeholders will mean
that users of your locale will have their emails converted to events
without datetime information in email used. Patterns with old
placeholders won't be used.

As of today locales having none or almost no patterns with placeholders
in new format are: an, ar, bg, br, el, eu, hr, hy-AM, id, lt, ro, tr, uz.
If your patterns were deleted by Pootle you can look them up from an
older revision of the file by using
https://hg.mozilla.org/releases/l10n/mozilla-aurora/yourlocalecodehere/log/tip/calendar/chrome/calendar/calendar-extract.properties
and re-add them with new placeholders.
If you never had patterns with placeholders translated you should try to
add a few for better quality.

For anyone interested in double-checking locales left using old style
placeholders (either for all patterns or some of them) are: ca, de, dsb,
en-GB, es-AR, fi, fy-NL, ga-IE, gd, gl, hsb, hu, ka, ko, nb-NO, nn-NO,
pa-IN, pl, pt-BR, ru, sk, sq, sv-SE, uk, zh-CN, zh-TW.

Merike

On 16.12.2015 23:30, Merike Sell wrote:

> Hi all,
>
> Bug 1154448 changed placeholder format used in
> calendar-extract.properties file. This is a technical change not
> affecting the meaning of patterns so the keys were not changed and
> dashboard won't notify you about it. The change does, however, require
> all locales to replace old placeholders with new ones so that Lightning
> could still provide users with automatically set dates and times when
> they convert an email to an event.
>
> Three replacements needed in calendar-extract.properties are as follows:
> %1$S -> #1
> %2$S -> #2
> %3$S -> #3
>
> If you work on files directly you can use your preferred text editor to
> make these replacements across the file. This only applies if you work
> on central or aurora as this change hasn't reached beta yet.
>
> If you cannot or don't want to make the changes yourself we can probably
> find a way to make them for you. Please let me know if you'd like to
> have it changed for your locale. (any of this list, email or irc will do)
>
> Merike
>

_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file (warning to Pootle locales)

Mihovil Stanić-2
Yes, noticed that last night for hr locale.
Why did place holders changed? Who cares if it's $1$S or #1?
$1$S is pretty much standard place holder for Mozilla, and #1 isn't, but
it's used in Lightning now...

Mihovil

17.01.2016 u 19:43, Merike Sell je napisao/la:

> For reasons I've been unable to find out on 24th December there were a
> number of commits from Pootle to different locale repositories that
> removed all/some previously translated patterns containing placeholders.
> If your locale is affected you may not have seen strings using old
> placeholders showing up on Pootle at all and were unable to apply
> updates. Instead the patterns would be untranslated.
>
> Having none or very few patterns with updated placeholders will mean
> that users of your locale will have their emails converted to events
> without datetime information in email used. Patterns with old
> placeholders won't be used.
>
> As of today locales having none or almost no patterns with placeholders
> in new format are: an, ar, bg, br, el, eu, hr, hy-AM, id, lt, ro, tr, uz.
> If your patterns were deleted by Pootle you can look them up from an
> older revision of the file by using
> https://hg.mozilla.org/releases/l10n/mozilla-aurora/yourlocalecodehere/log/tip/calendar/chrome/calendar/calendar-extract.properties
> and re-add them with new placeholders.
> If you never had patterns with placeholders translated you should try to
> add a few for better quality.
>
> For anyone interested in double-checking locales left using old style
> placeholders (either for all patterns or some of them) are: ca, de, dsb,
> en-GB, es-AR, fi, fy-NL, ga-IE, gd, gl, hsb, hu, ka, ko, nb-NO, nn-NO,
> pa-IN, pl, pt-BR, ru, sk, sq, sv-SE, uk, zh-CN, zh-TW.
>
> Merike
>
> On 16.12.2015 23:30, Merike Sell wrote:
>> Hi all,
>>
>> Bug 1154448 changed placeholder format used in
>> calendar-extract.properties file. This is a technical change not
>> affecting the meaning of patterns so the keys were not changed and
>> dashboard won't notify you about it. The change does, however, require
>> all locales to replace old placeholders with new ones so that Lightning
>> could still provide users with automatically set dates and times when
>> they convert an email to an event.
>>
>> Three replacements needed in calendar-extract.properties are as follows:
>> %1$S -> #1
>> %2$S -> #2
>> %3$S -> #3
>>
>> If you work on files directly you can use your preferred text editor to
>> make these replacements across the file. This only applies if you work
>> on central or aurora as this change hasn't reached beta yet.
>>
>> If you cannot or don't want to make the changes yourself we can probably
>> find a way to make them for you. Please let me know if you'd like to
>> have it changed for your locale. (any of this list, email or irc will do)
>>
>> Merike
>>
> _______________________________________________
> dev-l10n mailing list
> [hidden email]
> https://lists.mozilla.org/listinfo/dev-l10n

_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file (warning to Pootle locales)

Axel Hecht
In reply to this post by Merike Sell
On 18/01/16 08:19, Mihovil Stanić wrote:
> Yes, noticed that last night for hr locale.
> Why did place holders changed? Who cares if it's $1$S or #1?
> $1$S is pretty much standard place holder for Mozilla, and #1 isn't, but
> it's used in Lightning now...

The problem is that it's a pattern and not a placable. It was looking
like a printf placable, which triggered our build logic to apply printf
rules to it.
But to make things work, you had to break those rules.

Thus we switched it to use something as patterns that doesn't look like
printf.

Axel

>
> Mihovil
>
> 17.01.2016 u 19:43, Merike Sell je napisao/la:
>> For reasons I've been unable to find out on 24th December there were a
>> number of commits from Pootle to different locale repositories that
>> removed all/some previously translated patterns containing placeholders.
>> If your locale is affected you may not have seen strings using old
>> placeholders showing up on Pootle at all and were unable to apply
>> updates. Instead the patterns would be untranslated.
>>
>> Having none or very few patterns with updated placeholders will mean
>> that users of your locale will have their emails converted to events
>> without datetime information in email used. Patterns with old
>> placeholders won't be used.
>>
>> As of today locales having none or almost no patterns with placeholders
>> in new format are: an, ar, bg, br, el, eu, hr, hy-AM, id, lt, ro, tr, uz.
>> If your patterns were deleted by Pootle you can look them up from an
>> older revision of the file by using
>> https://hg.mozilla.org/releases/l10n/mozilla-aurora/yourlocalecodehere/log/tip/calendar/chrome/calendar/calendar-extract.properties
>>
>> and re-add them with new placeholders.
>> If you never had patterns with placeholders translated you should try to
>> add a few for better quality.
>>
>> For anyone interested in double-checking locales left using old style
>> placeholders (either for all patterns or some of them) are: ca, de, dsb,
>> en-GB, es-AR, fi, fy-NL, ga-IE, gd, gl, hsb, hu, ka, ko, nb-NO, nn-NO,
>> pa-IN, pl, pt-BR, ru, sk, sq, sv-SE, uk, zh-CN, zh-TW.
>>
>> Merike
>>
>> On 16.12.2015 23:30, Merike Sell wrote:
>>> Hi all,
>>>
>>> Bug 1154448 changed placeholder format used in
>>> calendar-extract.properties file. This is a technical change not
>>> affecting the meaning of patterns so the keys were not changed and
>>> dashboard won't notify you about it. The change does, however, require
>>> all locales to replace old placeholders with new ones so that Lightning
>>> could still provide users with automatically set dates and times when
>>> they convert an email to an event.
>>>
>>> Three replacements needed in calendar-extract.properties are as follows:
>>> %1$S -> #1
>>> %2$S -> #2
>>> %3$S -> #3
>>>
>>> If you work on files directly you can use your preferred text editor to
>>> make these replacements across the file. This only applies if you work
>>> on central or aurora as this change hasn't reached beta yet.
>>>
>>> If you cannot or don't want to make the changes yourself we can probably
>>> find a way to make them for you. Please let me know if you'd like to
>>> have it changed for your locale. (any of this list, email or irc will
>>> do)
>>>
>>> Merike
>>>
>> _______________________________________________
>> dev-l10n mailing list
>> [hidden email]
>> https://lists.mozilla.org/listinfo/dev-l10n
>

_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file (warning to Pootle locales)

Michael Wolf-2
In reply to this post by Merike Sell
Merike Sell schrieb:
>>
>> Three replacements needed in calendar-extract.properties are as follows:
>> %1$S -> #1
>> %2$S -> #2
>> %3$S -> #3
>>

Hi Merike,

I did all replacements for dsb and hsb.


Regards,

Michael


_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Stefan Sitter-2
In reply to this post by Merike Sell
On 16.12.2015 22:30, Merike Sell wrote:

> Bug 1154448 changed placeholder format used in
> calendar-extract.properties file. This is a technical change not
> affecting the meaning of patterns so the keys were not changed and
> dashboard won't notify you about it. The change does, however, require
> all locales to replace old placeholders with new ones so that Lightning
> could still provide users with automatically set dates and times when
> they convert an email to an event.
>
> Three replacements needed in calendar-extract.properties are as follows:
> %1$S -> #1
> %2$S -> #2
> %3$S -> #3
>
> If you work on files directly you can use your preferred text editor to
> make these replacements across the file. This only applies if you work
> on central or aurora as this change hasn't reached beta yet.
>
> If you cannot or don't want to make the changes yourself we can probably
> find a way to make them for you. Please let me know if you'd like to
> have it changed for your locale. (any of this list, email or irc will do)

Hello Merike,

I downloaded Lightning 4.7b1
<https://addons.mozilla.org/thunderbird/addon/lightning/versions/4.7b1>

Searching for %1$S in file calendar-extract.properties results in the
following languages that are still using the old format:

   ca
   de
   dsb
   en-GB
   es-AR
   et
   fi
   ga-IE
   gd
   hsb
   hu
   is
   it
   ko
   nb-NO
   nn-NO
   pl
   pt-BR
   sk
   sq
   sv-SE
   uk
   zh-CN
   zh-TW

Will they be automatically converted to the new format?
Or will they be excluded from the Lightning 4.7 release?

/Stefan
_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Merike Sell
On 15.02.2016 19:10, Stefan Sitter wrote:

> On 16.12.2015 22:30, Merike Sell wrote:
>> Bug 1154448 changed placeholder format used in
>> calendar-extract.properties file. This is a technical change not
>> affecting the meaning of patterns so the keys were not changed and
>> dashboard won't notify you about it. The change does, however, require
>> all locales to replace old placeholders with new ones so that Lightning
>> could still provide users with automatically set dates and times when
>> they convert an email to an event.
>>
>> Three replacements needed in calendar-extract.properties are as follows:
>> %1$S -> #1
>> %2$S -> #2
>> %3$S -> #3
>>
>> If you work on files directly you can use your preferred text editor to
>> make these replacements across the file. This only applies if you work
>> on central or aurora as this change hasn't reached beta yet.
>>
>> If you cannot or don't want to make the changes yourself we can probably
>> find a way to make them for you. Please let me know if you'd like to
>> have it changed for your locale. (any of this list, email or irc will do)
>
> Hello Merike,
>
> I downloaded Lightning 4.7b1
> <https://addons.mozilla.org/thunderbird/addon/lightning/versions/4.7b1>
>
> Searching for %1$S in file calendar-extract.properties results in the
> following languages that are still using the old format:
>
>   ca
>   de
>   dsb
>   en-GB
>   es-AR
>   et
>   fi
>   ga-IE
>   gd
>   hsb
>   hu
>   is
>   it
>   ko
>   nb-NO
>   nn-NO
>   pl
>   pt-BR
>   sk
>   sq
>   sv-SE
>   uk
>   zh-CN
>   zh-TW
>
> Will they be automatically converted to the new format?
> Or will they be excluded from the Lightning 4.7 release?
>
> /Stefan

Neither, as far as i know.

Automatic conversion on aurora repositories wasn't possible as Pootle
wouldn't have taken it well with locales working through Pootle. On beta
it might have been possible except that Pootle removed previously
localized strings from files based on the fact that original string had
changed (despite the keys not changing). If there are still strings
using old format on beta (I haven't checked yet) automatic conversion
can be discussed.

Exclusion is not required as I'm unaware of any cases where old strings
would break conversion. Rather conversion isn't as efficient as it could
be. That's a matter of localization quality, really. I'm not sure which
rules apply to sign-offs for Thunderbird but certainly Philipp (who I
think approves them) could require old format replaced or patterns added
if a locale has very few of them as a requirement for approval if he
decides to do so.

Also, for example et is currently shipping old format because of a
missing sign-off, perhaps there are more locales like that?

Merike
_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Michael Wolf-2
In reply to this post by Stefan Sitter-2
Stefan Sitter schrieb:

> Hello Merike,
>
> I downloaded Lightning 4.7b1
> <https://addons.mozilla.org/thunderbird/addon/lightning/versions/4.7b1>
>
> Searching for %1$S in file calendar-extract.properties results in the
> following languages that are still using the old format:
>
>    ca
>    de
>    dsb
>    en-GB
>    es-AR
>    et
>    fi
>    ga-IE
>    gd
>    hsb
>    hu
>    is
>    it
>    ko
>    nb-NO
>    nn-NO
>    pl
>    pt-BR
>    sk
>    sq
>    sv-SE
>    uk
>    zh-CN
>    zh-TW
>
> Will they be automatically converted to the new format?
> Or will they be excluded from the Lightning 4.7 release?
>

Hi Merike, hi Stefan,

I have already replaced the old variables by the new ones for dsb and
hsb on Pootle one month ago, on January 18:


> Michael Wolf schrieb:
>> Merike Sell schrieb:
>>>>
>>>> Three replacements needed in calendar-extract.properties are as follows:
>>>> %1$S -> #1
>>>> %2$S -> #2
>>>> %3$S -> #3
>>>>
>>
>> Hi Merike,
>>
>> I did all replacements for dsb and hsb.
>>
>>
>> Regards,
>>
>> Michael
>>

I don¨t understand why the replacements are not in the Lightning builds yet.


Kind regards,

Michael


_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Iacopo Benesperi-2
Michael Wolf ha scritto:
> I have already replaced the old variables by the new ones for dsb and
> hsb on Pootle one month ago, on January 18:
>
> I don¨t understand why the replacements are not in the Lightning builds
> yet.

Hi, same for me:
http://hg.mozilla.org/releases/l10n/mozilla-beta/it/rev/0af642363b43

Cheers,
Iacopo
_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Philipp Kewisch-2
On 2/18/16 12:07 AM, Iacopo Benesperi wrote:

> Michael Wolf ha scritto:
>> I have already replaced the old variables by the new ones for dsb and
>> hsb on Pootle one month ago, on January 18:
>>
>> I don¨t understand why the replacements are not in the Lightning builds
>> yet.
>
> Hi, same for me:
> http://hg.mozilla.org/releases/l10n/mozilla-beta/it/rev/0af642363b43
>
> Cheers,
> Iacopo
>

Hi Iacopo and Michael,

in your cases it is indeed the missing sign-off. You are in luck, I have
accepted the sign-off for it yesterday, and gd is covered by the mapit
changes sign-off I will accept just in time for beta 2, so you should be
good.

I haven't checked the other locales yet, but there was a big round of
sign-off reviews yesterday.

Philipp
_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Michael Wolf-2
Philipp Kewisch schrieb:

>
> Hi Iacopo and Michael,
>
> in your cases it is indeed the missing sign-off. You are in luck, I have
> accepted the sign-off for it yesterday, and gd is covered by the mapit
> changes sign-off I will accept just in time for beta 2, so you should be
> good.
>
> I haven't checked the other locales yet, but there was a big round of
> sign-off reviews yesterday.
>

Thank you, Philipp.


Michael

_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n
Reply | Threaded
Open this post in threaded view
|

Re: String changes in Lightning's calendar-extract.properties file

Besnik Bleta-3
In reply to this post by Merike Sell
Hello,

On 12/19/2015 09:52 PM, Merike Sell wrote:
> For anyone else curious I've started a spreadsheet [1] to track progress
> so far and requests for help. (this is for me, you don't need to do
> anything additional)
>
> Merike
>
> [1]
> https://docs.google.com/spreadsheets/d/1wIcoysgN0lI-2hdutjzHNGyCLjKpv2er6OjHtPHf2O8

I fixed that for sq as well.

Cheers,
Besnik

_______________________________________________
dev-l10n mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-l10n