Strike-through of bug numbers

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Strike-through of bug numbers

Martin-366
I've looked through the docs and the code, yet I cannot find the spot
that decides to display the bug numbers in strike-through text when
the status is Resolved or Closed.

I'd like to use the strike-through text *only* when a bug is closed,
and not for any other status.

How can I change this?  Thanks.
_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Peter Kay
Mike wrote:
> I've looked through the docs and the code, yet I cannot find the spot
> that decides to display the bug numbers in strike-through text when
> the status is Resolved or Closed.
>
> I'd like to use the strike-through text *only* when a bug is closed,
> and not for any other status.
>
> How can I change this?  Thanks.

"bz_closed" has style line-through in global.css (in css/ in 2.18, now
in skins/somethingorother/).

bz_closed is set in "GetBugLink" in global.pl and in a "closed" filter
in Bugzilla/Template.pm

You'll have to change some logic if you want to fix this, but shouldn't
be too hard.

--Peter
_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Martin-366
On Tue, 20 Sep 2005 17:25:13 -0400, Peter Kay
<[hidden email]> wrote:

>Mike wrote:
>> I've looked through the docs and the code, yet I cannot find the spot
>> that decides to display the bug numbers in strike-through text when
>> the status is Resolved or Closed.
>>
>> I'd like to use the strike-through text *only* when a bug is closed,
>> and not for any other status.
>>
>> How can I change this?  Thanks.
>
>"bz_closed" has style line-through in global.css (in css/ in 2.18, now
>in skins/somethingorother/).
>
>bz_closed is set in "GetBugLink" in global.pl and in a "closed" filter
>in Bugzilla/Template.pm
>
>You'll have to change some logic if you want to fix this, but shouldn't
>be too hard.

Excellent!  Thanks for the pointers.


_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Martin-366
On Wed, 21 Sep 2005 09:17:07 -0400, Mike <[hidden email]> wrote:

>On Tue, 20 Sep 2005 17:25:13 -0400, Peter Kay
><[hidden email]> wrote:
>
>>Mike wrote:
>>> I've looked through the docs and the code, yet I cannot find the spot
>>> that decides to display the bug numbers in strike-through text when
>>> the status is Resolved or Closed.
>>>
>>> I'd like to use the strike-through text *only* when a bug is closed,
>>> and not for any other status.
>>>
>>> How can I change this?  Thanks.
>>
>>"bz_closed" has style line-through in global.css (in css/ in 2.18, now
>>in skins/somethingorother/).
>>
>>bz_closed is set in "GetBugLink" in global.pl and in a "closed" filter
>>in Bugzilla/Template.pm
>>
>>You'll have to change some logic if you want to fix this, but shouldn't
>>be too hard.
>
>Excellent!  Thanks for the pointers.
>

btw, I decided to just change the style to underline instead of doing
all the logic changes.  At least the bug numbers are readable, which
is the main thing the users were raising concerns about.  At some
other point in time, I'll play with the logic such that olny closed
bugs are shown as being closed via the strikethrough.

btw, btw, while I was looking through the code, I noticed a function
OpenStates that listed what states were treated as being "open".


===
# This sub will return an array containing any status that
# is considered an open bug.

sub OpenStates {
    return ('NEW', 'REOPENED', 'ASSIGNED', $::unconfirmedstate);
}
===


I haven't followed through all the code yet, but if I add VERIFIED and
RESOLVED to that array, would that then make CLOSED the only status
that is treated as a closed bug?



_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Emmanuel Seyman
Mike wrote:
>
> I haven't followed through all the code yet, but if I add VERIFIED and
> RESOLVED to that array, would that then make CLOSED the only status
> that is treated as a closed bug?

Yes. There's no IsClosedState() function.
Anything that isn't Open is Closed.

            elsif (! IsOpenedState($bug_state)) {
                $pre = '<span class="bz_closed">';
                $title .= " $bug_res";
                $post = '</span>';
            }

Take note that doing this will also change the logic of the "Find a
Specific Bug" part of the query page.

Emmanuel

_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Martin-366
In reply to this post by Martin-366
On Thu, 22 Sep 2005 18:17:31 +0200 (CEST), "Emmanuel Seyman"
<[hidden email]> wrote:

>Mike wrote:
>>
>> I haven't followed through all the code yet, but if I add VERIFIED and
>> RESOLVED to that array, would that then make CLOSED the only status
>> that is treated as a closed bug?
>
>Yes. There's no IsClosedState() function.
>Anything that isn't Open is Closed.
>
>            elsif (! IsOpenedState($bug_state)) {
>                $pre = '<span class="bz_closed">';
>                $title .= " $bug_res";
>                $post = '</span>';
>            }
>
>Take note that doing this will also change the logic of the "Find a
>Specific Bug" part of the query page.

Yup, I saw that logic, that's how I wound up in the OpenStates
function.  :-)

Here we call a bug Closed only when its status is precisely and only
Closed.  (how odd is that?).  

We do not think that Resolved Fixed, for example, is a closed bug.  So
to see the search page and the rest of Bugzilla follow the logic of
"Closed is Closed" is a feature for us.  :-)

Thanks for the help.

_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Emmanuel Seyman
Mike wrote :
>
> Here we call a bug Closed only when its status is precisely and only
> Closed.  (how odd is that?).

Not very. :-)
https://bugzilla.mozilla.org/show_bug.cgi?id=308682

Emmanuel

_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Martin-366
In reply to this post by Martin-366
On Fri, 23 Sep 2005 16:59:04 +0200 (CEST), "Emmanuel Seyman"
<[hidden email]> wrote:

>Mike wrote :
>>
>> Here we call a bug Closed only when its status is precisely and only
>> Closed.  (how odd is that?).
>
>Not very. :-)
>https://bugzilla.mozilla.org/show_bug.cgi?id=308682


 :-)

Though, I'm not convinced the simple change from status to state or
vice versa will help reduce the confusion.  The problem is deeper than
that.


_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Bernd Eckenfels-4
In reply to this post by Martin-366
On Fri, Sep 23, 2005 at 10:04:27AM -0400, Mike wrote:
> We do not think that Resolved Fixed, for example, is a closed bug.  So
> to see the search page and the rest of Bugzilla follow the logic of
> "Closed is Closed" is a feature for us.  :-)

This depends, if you have the habit of closing a bug after you ship the
product, and you also use bug dependencies then you have a problem. Because
a bug A may depend on B. A cannot be resolved until B is closed. However
when you want to fix both in a release, you cant make that release. Thats
why it is more ligical to also consider resolved or at least verified bugs
as closed for this purpose.

Gruss
Bernd
_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools
Reply | Threaded
Open this post in threaded view
|

Re: Strike-through of bug numbers

Martin-366
In reply to this post by Martin-366
On Fri, 23 Sep 2005 20:01:31 +0200, Bernd Eckenfels
<[hidden email]> wrote:

>On Fri, Sep 23, 2005 at 10:04:27AM -0400, Mike wrote:
>> We do not think that Resolved Fixed, for example, is a closed bug.  So
>> to see the search page and the rest of Bugzilla follow the logic of
>> "Closed is Closed" is a feature for us.  :-)
>
>This depends, if you have the habit of closing a bug after you ship the
>product, and you also use bug dependencies then you have a problem. Because
>a bug A may depend on B. A cannot be resolved until B is closed. However
>when you want to fix both in a release, you cant make that release. Thats
>why it is more ligical to also consider resolved or at least verified bugs
>as closed for this purpose.

 

"However when you want to fix both in a release, you cant make that
release." - that sounds like a process rule gone awry, or even a error
in the design of the build process; and not a reason why resolved
should mean closed.

Maybe there should be a BUILDABLE status (or is that state?), instead
of overloading the meaning of CLOSED....   :-)



_______________________________________________
mozilla-webtools mailing list
[hidden email]
http://mail.mozilla.org/listinfo/mozilla-webtools