Removal of the NN4.6 table border color quirk

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Removal of the NN4.6 table border color quirk

Bernd-13
I would like to remove the table border color quirk that makes the
border color dependent on the background. The quirk is a pure NN4.6 quirk.

In quirks mode the following markup will produce a green border instead
of a gray (default) one.

<div style="background-color:green">
<table border="10">
<tr><td>foo</td></td>
</table>
</div>

There are two reasons why this should be removed:
1.) IE does not do this
2.) This creates problems when CSS is applied to the table as depending
on the actual background-color violates the CSS principles.
3.) This quirk is a major obstacle for
https://bugzilla.mozilla.org/show_bug.cgi?id=43178

The removal will include:
- removal of the quirk handling in content,
- removal of  NS_STYLE_BORDER_STYLE_BG_OUTSET,
NS_STYLE_BORDER_STYLE_BG_INSET
- removal of -moz-bg-outset -moz-bg-inset
- removal of the corresponding code paths in nsCSSRendering
- use of the quirks color shades in standards mode, they are brighter
than the existing standards mode color shades and match IE.

There is NS_STYLE_BORDER_STYLE_BG_SOLID which is used for <hr> tags this
one will remain. So the code removal will not reach its full potential.

The benefits are:
Code removal, better CSS styling even in quirks mode, IE compatibility

The risks is:
We will break pages that rely on this quirk. However to get the border
color cross browser people have used a workaround before.



Any objections?

Bernd

_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout
Reply | Threaded
Open this post in threaded view
|

Re: Removal of the NN4.6 table border color quirk

Boris Zbarsky
Bernd wrote:
> - use of the quirks color shades in standards mode, they are brighter
> than the existing standards mode color shades and match IE.

What does that correspond to as a code change?

> Any objections?

Sounds pretty good, in general.  ;)

-Boris
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout
Reply | Threaded
Open this post in threaded view
|

Re: Removal of the NN4.6 table border color quirk

Bernd-13
Boris Zbarsky schrieb:
> Bernd wrote:
>> - use of the quirks color shades in standards mode, they are brighter
>> than the existing standards mode color shades and match IE.
>
> What does that correspond to as a code change?
>
http://lxr.mozilla.org/seamonkey/source/layout/base/nsCSSColorUtils.cpp#71 
get rid of NS_Get3DColors and make  NS_GetSpecial3DColors return the
same Values as IE or at least the same as NS_Get3DColors for a white
background and black background.

Bernd
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout
Reply | Threaded
Open this post in threaded view
|

Re: Removal of the NN4.6 table border color quirk

Boris Zbarsky
In reply to this post by Boris Zbarsky
Bernd wrote:
> http://lxr.mozilla.org/seamonkey/source/layout/base/nsCSSColorUtils.cpp#71 
> get rid of NS_Get3DColors and make  NS_GetSpecial3DColors return the
> same Values as IE or at least the same as NS_Get3DColors for a white
> background and black background.

So right now, when is each of the two used?  We seem to use NS_Get3DColors for
inset/outset and NS_GetSpecial3DColors for ridge/groove?  Or something else?

-Boris
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout