Unfortunately, even WKWebKit does not fully support everything that Safari supports (well, this is plaguing Android Web View as well), so always make sure it works in WKWebKit, even if it works in Safari.
On Fri, May 25, 2018 at 7:44 PM Sylvain Defresne <[hidden email]> wrote:
Style guide deviation: It seems like an acceptable deviation because we don't have to deal with cross-browser compatibility, so only we only need to worry about Chrome's semantics, which have been implemented for 7 versions now. Furthermore, Closure library is basically a built-in with normal google code, so there's no reason for it there.
Related toolchain: I'm not super familiar with all the tools, so I don't know if it breaks any related toolchains. I know that It compiles and runs fine in the way I did it, and it works with es style presubmits with the .eslintrc.
Platforms: It's a feature of the browser and v8, not the OS? I'm not sure why it wouldn't be supported on iOS. I might be missing something.
On Friday, May 25, 2018 at 1:35:19 AM UTC-7, Mike Frysinger wrote:
a proposal to deviate from the agreed upon style guide should clearly explain why the deviation is acceptable.
On Fri, May 25, 2018 at 4:29 PM Michael Giuffrida <[hidden email]> wrote:
I'm not too concerned with the Google style guide's take on ES6 modules because Google practically treats the Closure library like a built-in, so they don't need modules due to universal goog.module and goog.require statements.
On Fri, May 25, 2018 at 1:21 AM Mike Frysinger <[hidden email]> wrote:
They've been supported in Chrome since M61. Seems like an elegant way to organize code if you're in an environment where you can make it work (Not having non-module code that needs to depend on you). I made it work for a self-contained component extension. A module author would need to add
to an .eslintrc to make the presubmits happy. js2g tests can be shoehorned to work with it by having it import an html file that contains something like
import * as devtools from './devtools.js';
window.devtools = devtools;
That seems like the least work infrastructure-wise, but if desired it could be made more elegant.