Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

classic Classic list List threaded Threaded
36 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Steve Wendt
On 2/19/2013 9:11 PM, Dave Yeo wrote:

> Shouldn't allotocated memory get freed when the program is shutdown even
> if a malloc is not freed?

I think PMMerge is notorious for leaking memory in some situations, and
a lot of code ends up going through that.

_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Paul Ratcliffe
In reply to this post by Dave Yeo-3
On Tue, 19 Feb 2013 21:11:05 -0800, Dave Yeo <[hidden email]> wrote:

> Shouldn't allotocated memory get freed when the program is shutdown even
> if a malloc is not freed?

Allotocated?

Depends who's doing the malloc'ing. If it's the app. then it will get freed
when it closes. If it's PM doing it, then that subsystem never terminates
and it can leak a bit.
_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Dave Yeo-3
In reply to this post by Alfredo Fernández Díaz
Alfredo Fernández Díaz wrote:

> Dave Yeo escribió:
> ...
>> Are you sure it doesn't happen for you with PS files?
>> I just tested with a large page (The Config.sys Documentation
>> Project/OS/2-eCS
>> Commands - EDM2) and got these results,
>> 2-19-13 8:54p 810665 0 test1.ps
>> 2-19-13 8:54p 30779283 34 test2.ps
>> 2-19-13 8:55p 30788083 34 test3.ps
>  > With test1.ps looking very good in GSVIEW while test2 and test3 looked
>  > somewhat washed out but was readable unlike my PDF tests. I also lost
>  > over 40 MBs of shared memory even after shutting down Firefox. That
>  > includes testing PDF, closing Firefox then testing PS.
>
> Positive, 100% sure. Running SeaMonkey 2.7.2 (esr9 I think, but the
> surface corruption on PDF generation was first reported circa FX v6 so
> no big deal) I just printed two 100+ page PDFs and they had missing
> characters, etc. which means I probably had done some printing before
> (been running for a couple of days so I don't remember). Then I printed
> the exact same two documents to PS and they look perfect in GView, and
> in Lucide when converted to PDF later.

Which printer driver are you using?
Dave
_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Dave Yeo-3
In reply to this post by Dave Yeo-3
Dave Yeo wrote:
> Be nice to figure out where the buffer corruption is happening for PDF
> files.

I backed out all of Rich's printing patches and PDF files were still
corrupted so the problem is somewhere besides our printing code.
Without Rich's patches, attempting to print without a printer driver
fails much the same as with the new fix except print preview fails with
a better message mentioning the reason for failure instead of unknown error.
Dave
_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Alfredo Fernández Díaz
In reply to this post by Dave Yeo-3
Dave Yeo escribió:
> Alfredo Fernández Díaz wrote:
>> ...
>> I just printed two 100+ page PDFs and they had missing
>> characters, etc. which means I probably had done some printing before
>> (been running for a couple of days so I don't remember). Then I printed
>> the exact same two documents to PS and they look perfect in GView, and
>> in Lucide when converted to PDF later.
>
> Which printer driver are you using?

PSPRINT.DRV, Preview release 3: Dec 18 2010 by Alex Taylor.

but I have

print.os2.postscript.use_builtin = true
print.os2.postscript.use_ibmnull = true

so I think the PS files I generate don't really go through PSPRINT.

Regards,
Alfred.
_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Dave Yeo-3
Alfredo Fernández Díaz wrote:

>> Which printer driver are you using?
>
> PSPRINT.DRV, Preview release 3: Dec 18 2010 by Alex Taylor.
>
> but I have
>
> print.os2.postscript.use_builtin = true
> print.os2.postscript.use_ibmnull = true
>
> so I think the PS files I generate don't really go through PSPRINT.

I only have print.os2.postscript.use_builtin which is set to false. When
ever I reboot to a system with a printer driver, I'll test.
Dave

_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Lars Erdmann
In reply to this post by Steve Wendt
See bug 707864. I even gave the solution. It's in the bug description.



"Steve Wendt" <[hidden email]> schrieb im Newsbeitrag
news:[hidden email]...

> On 02/15/13 03:16 pm, Roderick Klein wrote:
>
>> On this eCS test install I have NO printers installed.
>> When in Firefox I press the print button the browser crashes.
>
> This bug has existed for several years:
> https://bugzilla.mozilla.org/show_bug.cgi?id=377497
> https://bugzilla.mozilla.org/show_bug.cgi?id=707864
>
> Are you just now finding it?

_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta... - I DID give the solution !

Lars Erdmann
In reply to this post by Steve Wendt
See bug 707864, I even gave the solution. It's in the bug description.

"Steve Wendt" <[hidden email]> schrieb im Newsbeitrag
news:[hidden email]...

> On 02/15/13 03:16 pm, Roderick Klein wrote:
>
>> On this eCS test install I have NO printers installed.
>> When in Firefox I press the print button the browser crashes.
>
> This bug has existed for several years:
> https://bugzilla.mozilla.org/show_bug.cgi?id=377497
> https://bugzilla.mozilla.org/show_bug.cgi?id=707864
>
> Are you just now finding it?

_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Dave Yeo-3
In reply to this post by Lars Erdmann
Lars Erdmann wrote:
> See bug 707864. I even gave the solution. It's in the bug description.

The problem was/is with Rich's patches, which didn't handle having no
printer. Without the patches your fix isn't needed as it fails gracefully.
Dave
_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Alfredo Fernández Díaz
Dave Yeo escribió:
> Lars Erdmann wrote:
>> See bug 707864. I even gave the solution. It's in the bug description.
>
> The problem was/is with Rich's patches, which didn't handle having no printer.
> Without the patches your fix isn't needed as it fails gracefully.

But what other problems do we have without the patches?

I guess Rich must have made his changes for a reason, even if maybe he
overlooked he was introducing a potential pitfall. Can't we have everything in
a single patch set?

_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Dave Yeo-3
On 02/24/13 01:01 pm, Alfredo Fernández Díaz wrote:
> Dave Yeo escribió:
>> Lars Erdmann wrote:
>>> See bug 707864. I even gave the solution. It's in the bug description.
>>
>> The problem was/is with Rich's patches, which didn't handle having no
>> printer.
>> Without the patches your fix isn't needed as it fails gracefully.
>
> But what other problems do we have without the patches?

No printing except to PDFs (which are also currently broken in the same
way as they are with Rich's patches) on the desktop and low resolution
drivers such as the faxworks driver. He also did quite a bit of work to
speed things up using DIVE.

>
> I guess Rich must have made his changes for a reason, even if maybe he
> overlooked he was introducing a potential pitfall. Can't we have
> everything in a single patch set?

They're split up into 8 patches as it's logical to do, different
targets, some debugging support and such. It also makes it much easier
to maintain.
Dave


_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

mozilla_test
In reply to this post by Alfredo Fernández Díaz
hello Dave,

> No printing except to PDFs (which are also currently broken in the same
> way as they are with Rich's patches) on the desktop and low resolution
> drivers such as the faxworks driver. He also did quite a bit of work to
> speed things up using DIVE.

the last one is maybe just more than dive, he refreshed the multimedia
stuff for OS/2. I think without this work webm wouldn't work at all.

--
cheers
mozilla_test
_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Dave Yeo-3
mozilla_test wrote:
> hello Dave,
>
>> No printing except to PDFs (which are also currently broken in the same
>> way as they are with Rich's patches) on the desktop and low resolution
>> drivers such as the faxworks driver. He also did quite a bit of work to
>> speed things up using DIVE.
>
> the last one is maybe just more than dive, he refreshed the multimedia
> stuff for OS/2. I think without this work webm wouldn't work at all.

I was talking about just the printer related stuff, he updated Cairo
quite a bit (Cairo does all the drawing) and added an OS/2 print surface
and also updated quite a bit of Mozilla code to take advantage of the
new printing surface.
He did do a lot of the audio work which made things a lot smoother
compared to Peter's original code and added the OS/2 threading to libvpx
after I got the assembly working.
Dave

_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

T.-4
In reply to this post by Ray Davison
Hi,

> How about none.  Mozilla products are too easy for the user to install,
> and have no business being on a boot partition anyway
people expect a browser and an e-mail-program in a standard-install.

And at least some users will be overextended to download a webbrowser
somewhere, transfer it to the new installed eCS and install it - it's
just not that easy to download any software from the web, if you do not
have a webbrowser at all.

A possibility might be, putting a stable installation package in the net
and program a "one-click-install" around wget to get it on your system.
But this will not work if you have no or only a very slow internet
connection.
--
To Answer please replace "invalid" with "de" !
Zum Antworten bitte "invalid" durch "de" ersetzen !


Chau y hasta luego,

Thorolf
_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

Ray Davison
T. wrote:
>
> And at least some users will be overextended to download a webbrowser
> somewhere, transfer it to the new installed eCS and install it - it's
> just not that easy to download any software from the web, if you do not
> have a webbrowser at all.

What do you see as the profile of a person who is acquiring eCS and does
not currently have a functioning system including a browser?  I started
with the assumption that such a person does not exist.  So who is this
person?

Ray


_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
Reply | Threaded
Open this post in threaded view
|

Re: Which version to include of Firefox and Thunderbird in eCS 2.2 beta...

or-13
Ray Davison wrote:

> T. wrote:
>>
>> And at least some users will be overextended to download a webbrowser
>> somewhere, transfer it to the new installed eCS and install it - it's
>> just not that easy to download any software from the web, if you do not
>> have a webbrowser at all.
>
> What do you see as the profile of a person who is acquiring eCS and does
> not currently have a functioning system including a browser?  I started
> with the assumption that such a person does not exist.  So who is this
> person?
>
> Ray
>
>

Someone who is installing eCs as a new system on a PC without other
OS's. Then, one needs to do some type of file transfer of the
installation code (flash drive, ftp - unsafe, etc.,) a needless hassle.

Just try uninstalling the browsers on your system, and see how easy it
is then to download files.

Cheers,

Oscar Rondon
_______________________________________________
dev-ports-os2 mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-ports-os2
12