Re: Intent to remove: Error Console

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Intent to remove: Error Console

Philipp Kewisch-2
On 6/6/16 10:04 PM, Brian Grinstead wrote:
> There is an Error Console feature in toolkit that's been replaced by the Browser Console.  We'd like to remove associated code in toolkit/components/console/ and the component in bugzilla (Toolkit: Error Console).  This will also remove the —jsconsole command line flag for consumers that don’t use devtools.
>
> The code isn't used at all in Firefox, as discussed in https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4/discussion.  It’s also now possible to migrate usages to the Browser Console i.e. Seamonkey is no longer using it as of bug 1223341.
>
> Brian
>

Looks like we finally have to do something, I guess it is time to test
the devtools client code in Thunderbird.

Philipp
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Intent to remove: Error Console

ISHIKAWA,chiaki
Philipp Kewisch wrote:

> On 6/6/16 10:04 PM, Brian Grinstead wrote:
>> There is an Error Console feature in toolkit that's been replaced by the Browser Console.  We'd like to remove associated code in toolkit/components/console/ and the component in bugzilla (Toolkit: Error Console).  This will also remove the —jsconsole command line flag for consumers that don’t use devtools.
>>
>> The code isn't used at all in Firefox, as discussed in https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4/discussion.  It’s also now possible to migrate usages to the Browser Console i.e. Seamonkey is no longer using it as of bug 1223341.
>>
>> Brian
>>
>
> Looks like we finally have to do something, I guess it is time to test
> the devtools client code in Thunderbird.
>
> Philipp

Is this "Error Console" the one we can invoke from "Tools" menu from the
menu bar?

Losing that means we will lose a good means of error reporting in TB.
Correct?


_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Intent to remove: Error Console

Philipp Kewisch-2
In reply to this post by Philipp Kewisch-2
On 6/7/16 5:17 PM, ISHIKAWA,chiaki wrote:

> Philipp Kewisch wrote:
>> On 6/6/16 10:04 PM, Brian Grinstead wrote:
>>> There is an Error Console feature in toolkit that's been replaced by
>>> the Browser Console.  We'd like to remove associated code in
>>> toolkit/components/console/ and the component in bugzilla (Toolkit:
>>> Error Console).  This will also remove the —jsconsole command line
>>> flag for consumers that don’t use devtools.
>>>
>>> The code isn't used at all in Firefox, as discussed in
>>> https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4/discussion.
>>> It’s also now possible to migrate usages to the Browser Console i.e.
>>> Seamonkey is no longer using it as of bug 1223341.
>>>
>>> Brian
>>>
>>
>> Looks like we finally have to do something, I guess it is time to test
>> the devtools client code in Thunderbird.
>>
>> Philipp
>
> Is this "Error Console" the one we can invoke from "Tools" menu from the
> menu bar?
>
> Losing that means we will lose a good means of error reporting in TB.
> Correct?
>
>
Yes, that is the thing. I'm going to do a quick check to see if it is
simple to integrate the browser console and will post a patch if so.

We'll definitely want to either import the code into c-c or work towards
a replacement to keep this feature. I'd prefer making the devtools
browser console work.

Philipp
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Intent to remove: Error Console

Philipp Kewisch-2
In reply to this post by Philipp Kewisch-2
On 6/7/16 12:10 PM, Philipp Kewisch wrote:

> On 6/6/16 10:04 PM, Brian Grinstead wrote:
>> There is an Error Console feature in toolkit that's been replaced by the Browser Console.  We'd like to remove associated code in toolkit/components/console/ and the component in bugzilla (Toolkit: Error Console).  This will also remove the —jsconsole command line flag for consumers that don’t use devtools.
>>
>> The code isn't used at all in Firefox, as discussed in https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4/discussion.  It’s also now possible to migrate usages to the Browser Console i.e. Seamonkey is no longer using it as of bug 1223341.
>>
>> Brian
>>
>
> Looks like we finally have to do something, I guess it is time to test
> the devtools client code in Thunderbird.
>
> Philipp
>

Got it working, please test the try builds linked from
https://bugzilla.mozilla.org/show_bug.cgi?id=1243550 once they are done.

Philipp
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Intent to remove: Error Console

ISHIKAWA,chiaki
On 2016年06月08日 08:36, Philipp Kewisch wrote:

> On 6/7/16 12:10 PM, Philipp Kewisch wrote:
>> On 6/6/16 10:04 PM, Brian Grinstead wrote:
>>> There is an Error Console feature in toolkit that's been replaced by the Browser Console.  We'd like to remove associated code in toolkit/components/console/ and the component in bugzilla (Toolkit: Error Console).  This will also remove the —jsconsole command line flag for consumers that don’t use devtools.
>>>
>>> The code isn't used at all in Firefox, as discussed in https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4/discussion.  It’s also now possible to migrate usages to the Browser Console i.e. Seamonkey is no longer using it as of bug 1223341.
>>>
>>> Brian
>>>
>>
>> Looks like we finally have to do something, I guess it is time to test
>> the devtools client code in Thunderbird.
>>
>> Philipp
>>
>
> Got it working, please test the try builds linked from
> https://bugzilla.mozilla.org/show_bug.cgi?id=1243550 once they are done.
>
> Philipp
>

This is great!

(except probably I have to re-create some patches that invokes message
printing from within C++ code into error-console.
Hmm.)

TIA

_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Intent to remove: Error Console

ISHIKAWA,chiaki
ishikawa wrote:

> On 2016年06月08日 08:36, Philipp Kewisch wrote:
>> On 6/7/16 12:10 PM, Philipp Kewisch wrote:
>>> On 6/6/16 10:04 PM, Brian Grinstead wrote:
>>>> There is an Error Console feature in toolkit that's been replaced by the Browser Console.  We'd like to remove associated code in toolkit/components/console/ and the component in bugzilla (Toolkit: Error Console).  This will also remove the —jsconsole command line flag for consumers that don’t use devtools.
>>>>
>>>> The code isn't used at all in Firefox, as discussed in https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4/discussion.  It’s also now possible to migrate usages to the Browser Console i.e. Seamonkey is no longer using it as of bug 1223341.
>>>>
>>>> Brian
>>>>
>>>
>>> Looks like we finally have to do something, I guess it is time to test
>>> the devtools client code in Thunderbird.
>>>
>>> Philipp
>>>
>>
>> Got it working, please test the try builds linked from
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1243550 once they are done.
>>
>> Philipp
>>
>
> This is great!
>
> (except probably I have to re-create some patches that invokes message
> printing from within C++ code into error-console.
> Hmm.)
>
> TIA
>
It is great that webconsole works as Error Console from the menu.

I am testing the new error console under Linux.

The color coordination leaves something desired for now.
That aside, when I tried to view an error's source file, I noticed the
following warning.

DEPRECATION WARNING: The arguments you're passing to viewSource.xul are
using an out-of-date API.
You may find more details about this deprecation at:
https://developer.mozilla.org/en-US/Add-ons/Code_snippets/View_Source_for_XUL_Applications
chrome://global/content/viewSource.js 329 _loadViewSourceDeprecated
chrome://global/content/viewSource.js 309 onXULLoaded
chrome://global/content/viewSource.js 175 handleEvent

This sounds to me that the API to position and select the target line in
view window is outdated.

One other thing.
Can the messages that appear in the console be time-stamped?
(Messages without timestamps are  pretty much useless from the viewpoint
of corelating the buggy behavior that happens unattended and the
messages recorded in Log console.)

TIA


_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Intent to remove: Error Console

Philipp Kewisch-2
In reply to this post by ISHIKAWA,chiaki
On 6/10/16 9:02 PM, ISHIKAWA,chiaki wrote:

> The color coordination leaves something desired for now.
You could try setting devtools.theme to "dark" or "firebug", but I don't
think it will make much difference. If you have suggestions on
improvements, please file bugs in the devtools component.

> That aside, when I tried to view an error's source file, I noticed the
> following warning.
> DEPRECATION WARNING: The arguments you're passing to viewSource.xul are
> using an out-of-date API.
> You may find more details about this deprecation at:
> https://developer.mozilla.org/en-US/Add-ons/Code_snippets/View_Source_for_XUL_Applications
>
> chrome://global/content/viewSource.js 329 _loadViewSourceDeprecated
> chrome://global/content/viewSource.js 309 onXULLoaded
> chrome://global/content/viewSource.js 175 handleEvent
>
> This sounds to me that the API to position and select the target line in
> view window is outdated.

The API being used is toolkit API called from devtools code, so they'll
eventually fix it and we'll get that fix for free.


> One other thing.
> Can the messages that appear in the console be time-stamped?
> (Messages without timestamps are  pretty much useless from the viewpoint
> of corelating the buggy behavior that happens unattended and the
> messages recorded in Log console.)

You can set devtools.webconsole.timestampMessages = true in the config
editor. This will become easier to do once I get the patch for
supporting the whole toolbox ready.

Philipp
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Intent to remove: Error Console

ISHIKAWA,chiaki


On 2016年06月11日 04:16, Philipp Kewisch wrote:> On 6/10/16 9:02 PM,
ISHIKAWA,chiaki wrote:
>
>> The color coordination leaves something desired for now.
> You could try setting devtools.theme to "dark" or "firebug", but I don't
> think it will make much difference. If you have suggestions on
> improvements, please file bugs in the devtools component.
>

I will see how it fares.
The current color scheme was not easy on old eyes ! :-)

>> That aside, when I tried to view an error's source file, I noticed the
>> following warning.
>> DEPRECATION WARNING: The arguments you're passing to viewSource.xul are
>> using an out-of-date API.
>> You may find more details about this deprecation at:
>> https://developer.mozilla.org/en-US/Add-ons/Code_snippets/View_Source_for_XUL_Applications
>>
>> chrome://global/content/viewSource.js 329 _loadViewSourceDeprecated
>> chrome://global/content/viewSource.js 309 onXULLoaded
>> chrome://global/content/viewSource.js 175 handleEvent
>>
>> This sounds to me that the API to position and select the target line in
>> view window is outdated.
>
> The API being used is toolkit API called from devtools code, so they'll
> eventually fix it and we'll get that fix for free.
>

All right. We should simply wait then.

>
>> One other thing.
>> Can the messages that appear in the console be time-stamped?
>> (Messages without timestamps are  pretty much useless from the viewpoint
>> of corelating the buggy behavior that happens unattended and the
>> messages recorded in Log console.)
>
> You can set devtools.webconsole.timestampMessages = true in the config
> editor. This will become easier to do once I get the patch for
> supporting the whole toolbox ready.

I will set the config param.

Thank you again!

Chiaki
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird