Re: Changes to how default permissions are setup in Firefox 35

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Changes to how default permissions are setup in Firefox 35

Matthew N.-2
----- Original Message -----

> From: "Mark Finkle" <[hidden email]>
> To: "Gavin Sharp" <[hidden email]>
> Cc: "Mark Hammond" <[hidden email]>, "Firefox Dev"
> <[hidden email]>
> Sent: Wednesday, September 24, 2014 9:43:43 PM
> Subject: Re: Changes to how default permissions are setup in Firefox 35

> ----- Original Message -----

> > This change has no impact on what Firefox users can do - the
>
> > permissions UI and behavior is not changing. The only visible behavior
>
> > change for users is that you won't lose the default permissions when
>
> > you clear "Site Permissions" in "Clear Recent History".
>
> Do these changes affect Firefox on Desktop only? If not, what bugs are filed
> for other apps?

Sorry I didn't catch in my review that there was a use of PermissionsUtils in mobile so add-on/app/LWT installation (perhaps only in new profiles depending on how the exception propagates) is probably broken. I filed bug 1072744[1] for mobile but perhaps we should just backout bug 1050080 for now until that's resolved. I will file a bug for thunderbird and seamonkey too.

I also noticed that the default location for the the default permission file is hard-coded to include "/browser/" in the path which seems unusual for code living in extensions/cookie/nsPermissionManager.cpp .

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1072744 
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Changes to how default permissions are setup in Firefox 35

Mark Finkle-2
----- Original Message -----

> ----- Original Message -----
> Sorry I didn't catch in my review that there was a use of PermissionsUtils in
> mobile so add-on/app/LWT installation (perhaps only in new profiles
> depending on how the exception propagates) is probably broken. I filed bug
> 1072744[1] for mobile but perhaps we should just backout bug 1050080 for now
> until that's resolved. I will file a bug for thunderbird and seamonkey too.

Backing out might be the easiest solution for now. I noticed that installing LWT from AMO is busted in Nightly now. Add-ons can still be installed though. I have not tested WebApps.

> I also noticed that the default location for the the default permission file
> is hard-coded to include "/browser/" in the path which seems unusual for
> code living in extensions/cookie/nsPermissionManager.cpp .

Agreed
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Changes to how default permissions are setup in Firefox 35

Ehsan Akhgari
In reply to this post by Matthew N.-2
On 2014-09-25, 1:15 AM, Matthew N. wrote:
> I also noticed that the default location for the the default permission
> file is hard-coded to include "/browser/" in the path which seems
> unusual for code living in extensions/cookie/nsPermissionManager.cpp.

Yeah, that's clearly broken!

_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Changes to how default permissions are setup in Firefox 35

Neil-4
In reply to this post by Mark Finkle-2
Mark Finkle wrote:

>I noticed that installing LWT from AMO is busted in Nightly now. Add-ons can still be installed though. I have not tested WebApps.
>
In a build from August 1st, accessing navigator.mozApps throws a
NS_ERROR_FACTORY_NOT_REGISTERED exception if Webapps.jsm hasn't been
loaded (which Thunderbird doesn't do, of course). This causes installing
LWT from AMO to fail. On trunk something else is busted because
NS_ERROR_FAILURE is thrown instead.

--
Warning: May contain traces of nuts.
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Changes to how default permissions are setup in Firefox 35

Philip Chee
In reply to this post by Mark Finkle-2
On 26/09/2014 00:01, Mark Finkle wrote:

> ----- Original Message -----
>
>> ----- Original Message -----
>> Sorry I didn't catch in my review that there was a use of PermissionsUtils in
>> mobile so add-on/app/LWT installation (perhaps only in new profiles
>> depending on how the exception propagates) is probably broken. I filed bug
>> 1072744[1] for mobile but perhaps we should just backout bug 1050080 for now
>> until that's resolved. I will file a bug for thunderbird and seamonkey too.
>
> Backing out might be the easiest solution for now. I noticed that installing LWT from AMO is busted in Nightly now. Add-ons can still be installed though. I have not tested WebApps.
>
>> I also noticed that the default location for the the default permission file
>> is hard-coded to include "/browser/" in the path which seems unusual for
>> code living in extensions/cookie/nsPermissionManager.cpp .
>
> Agreed

http://mxr.mozilla.org/mozilla-central/source/extensions/cookie/nsPermissionManager.cpp?rev=4223912e9f76#368

"resource://app/chrome/browser/default_permissions"

The second thing wrong is that the path should be resource:/// not
resource://app/ . This would break things such as metro and xulrunner.
Fortunately metro isn't built any more and xulrunner is currently
"unsupported"

Phil

--
Philip Chee <[hidden email]>, <[hidden email]>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: Changes to how default permissions are setup in Firefox 35

Philip Chee
On 26/09/2014 15:59, Philip Chee wrote:

> The second thing wrong is that the path should be resource:/// not
> resource://app/ . This would break things such as metro and xulrunner.
> Fortunately metro isn't built any more and xulrunner is currently
> "unsupported"

Replying to myself it seems that now resouce://app/ always points to
resource:///

See:
Bug 620931 part 4 - Fix resource://app/ to always point to the same as
resource:///
http://hg.mozilla.org/mozilla-central/rev/9df6e8117fe0

Phil

--
Philip Chee <[hidden email]>, <[hidden email]>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird