Question on line boxes and justification

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Question on line boxes and justification

Boris Zbarsky
I'm trying to figure out how justification affects nsLineBoxes (for bug 309761).
  It looks like it updates the mData->mCombinedArea but not the mBounds at the
moment.  Should it just be updating the mBounds?  Or should painting text
decorations use mData->mCombinedArea?  Based on the comments around the latter,
it sounds like it might include rel pos inlines, in which case using it for
text-decoration would be wrong.

Anyone know how this stuff works?

-Boris
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout
Reply | Threaded
Open this post in threaded view
|

Re: Question on line boxes and justification

Robert O'Callahan-3
Boris Zbarsky wrote:
> I'm trying to figure out how justification affects nsLineBoxes (for bug
> 309761).  It looks like it updates the mData->mCombinedArea but not the
> mBounds at the moment.  Should it just be updating the mBounds?  Or
> should painting text decorations use mData->mCombinedArea?  Based on the
> comments around the latter, it sounds like it might include rel pos
> inlines, in which case using it for text-decoration would be wrong.
>
> Anyone know how this stuff works?

Your patch is correct. The linebox mBounds should be increased to
account for justification.

Rob
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout