Post-reflow branch (probably post 1.9) float reflow changes

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Post-reflow branch (probably post 1.9) float reflow changes

Robert O'Callahan-3
Post-reflow-branch, I believe we can compute the width of a float when
we reflow the line it's on, without reflowing the float itself. Then it
would be nice to delay reflowing and placing floats until after we've
reflowed the line's in-flow content and we know exactly which floats are
on the line. This would avoid situations where we reflow and place some
floats and then later have to back out those changes and do them again
on the next line.

Rob
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout
Reply | Threaded
Open this post in threaded view
|

Re: Post-reflow branch (probably post 1.9) float reflow changes

L. David Baron
On Tuesday 2006-06-20 11:30 +1200, Robert O'Callahan wrote:
> Post-reflow-branch, I believe we can compute the width of a float when
> we reflow the line it's on, without reflowing the float itself. Then it
> would be nice to delay reflowing and placing floats until after we've
> reflowed the line's in-flow content and we know exactly which floats are
> on the line. This would avoid situations where we reflow and place some
> floats and then later have to back out those changes and do them again
> on the next line.

I'd rather move in the other direction:  don't reflow a float again when
moving it around.  The only case that requires a new reflow when
changing positions is a quirk that I'm somewhat skeptical we even need;
unfortunately the code is designed around that quirk, making it hard to
fix https://bugzilla.mozilla.org/show_bug.cgi?id=50630 , which is
another reason we need to move floats after placing them.

-David

--
L. David Baron                                <URL: http://dbaron.org/ >
           Technical Lead, Layout & CSS, Mozilla Corporation

_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Post-reflow branch (probably post 1.9) float reflow changes

Robert O'Callahan-3
In reply to this post by Robert O'Callahan-3
L. David Baron wrote:
> I'd rather move in the other direction:  don't reflow a float again when
> moving it around.  The only case that requires a new reflow when
> changing positions is a quirk that I'm somewhat skeptical we even need;
> unfortunately the code is designed around that quirk, making it hard to
> fix https://bugzilla.mozilla.org/show_bug.cgi?id=50630 , which is
> another reason we need to move floats after placing them.

That would work ... the key thing is to separate reflow and placement.

In general, I don't think we'll always be able to rely on a block
frame's continuations always having the same available width, in which
case we would need to reflow floats sometimes when moving them across
break boundaries. But that doesn't have to determine this.

Rob
_______________________________________________
dev-tech-layout mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-layout