Plan for Fx2 Alpha 2

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Plan for Fx2 Alpha 2

Mike Connor-3
Hey all,

A bunch of work has happened in #bonecho/#developers on irc over the
last few days - I thought I'd try and summarize it and detail the plan
for FFa2.

During the checkin of the major features for a2 we had a series of
increasing performance and memory regressions:

Startup time (Ts) on trunk: http://tinyurl.com/gcyfe
Startup time (Ts) on Branch: http://tinyurl.com/kzl4r
RefCnt Leaks on Trunk: http://tinyurl.com/e6ueq

More details in an earlier post:
http://groups.google.com/group/mozilla.dev.planning/browse_frm/thread/cc705603022ba6d4/185428251f061cd8#185428251f061cd8

This resulted in a closure of both the Trunk and 1.8 branches so we
could sort out what the different causes of the regressions were.
(http://www.mozilla.org/hacking/regression-policy.html)

As you can see most of them are under control at this point thanks to
the hard work of bz, dietrich, myk, shaver, gavin and others who I'm
forgetting to name.

The leaks were controllable via code fixes.  The Ts regressions have
turned out to be more difficult and we are currently in the following state:
     a) SafeBrowsing was backed out due to a 15-20% increase in Ts and
        equivalent damage to leaks.  The team is actively addressing the
        issues
     b) Session Restore is checked into both trees. It is disabled on
        trunk and enabled on branch.  Currently it's causing ~6%
        regression on branch due to JS component loading issues.
        Dietrich and bz are working on a fix.  All leak issues have been
        fixed in both trees.  Since the regression is small, isolated,
        understood, and being actively worked on we are going to leave in
        on the branch for now.  If one of those constraints change we'll
        configure it off.
     c) uSumaries seems to be ok for both leaks and Ts at this point.
     d) DOM Storage was backed out of both trees because of build bustage
        and performance regressions.  Team is working on better plan for
        build issues and will re-land once that and leak issues are

        addressed.

The trunk is currently closed to allow shakeout from Darin's threads
patch.   Current thought is to re-open it tomorrow (see earlier thread
in this ng for more details).

Here's the plan for a2:

We'd like to ship a2 tomorrow.  This will include SessionRestore and
uSummaries but not DOM Storage or SafeBrowsing.   It will including the
the leak/performance patches plus three regression fixes delivered over
the last few days:
     337292: Searchbar flex works better on Mac
     336945: can't use "Use a Web Site" when no local RSS handler
             is installed
     337305: unhork adding a new bookmark from the bookmarks manager

Since all the code is in we just need to do build/qa qualification
tomorrow to be ready for release (assuming there are no major issues).

Once the trunk re-opens the first priority will be re-sync the trunk and
branch for changes over the last few days.   Once that is complete we
will re-open the 1.8 branch.

We'd like DOMStorage and SafeBrowsing in a3.  So once the
perf/leak/regression work is completed on them we should schedule them
to land independently on the trunk then the branch.

There were a ton of lessons (re)learned here, but Schrep will be posting
about that later on.

This sound like a plan?  Any objections/rash insults?

-- Mike
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Mark Pilgrim
On 5/10/06, Mike Connor <[hidden email]> wrote:
> We'd like DOMStorage and SafeBrowsing in a3.

a3?

--
Cheers,
-Mark
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Mike Beltzner
As discussed at the last Firefox 2 meeting, "perhaps we can do a  
short cycle A2 and spin out an A3 at the end of the month." I think  
that if we want these two features in the product (which we do), then  
we need to quickly get them into an alpha-quality build and push that  
build out for people to start using.

We need to come up with some better scheduling for this, though,  
which I hope will shake out in the near future. We need target dates  
for:

  - re-opening trunk (tomorrow)
  - sync up between branch and trunk (2 days?)
  - controlled landing of DOMStorage (1 day?)
  - controlled landing of SafeBrowsing (1 day?)
  - re-open branch for bugfixes (2 days?)
  - code freeze for A3 (May 23rd?)
  - release of A3 (May 25th?)

Just spitballin' here.

mike

On 11-May-06, at 1:07 AM, Mark Pilgrim wrote:

> On 5/10/06, Mike Connor <[hidden email]> wrote:
>> We'd like DOMStorage and SafeBrowsing in a3.
>
> a3?
>
> --
> Cheers,
> -Mark
> _______________________________________________
> dev-planning mailing list
> [hidden email]
> https://lists.mozilla.org/listinfo/dev-planning

_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Boris Zbarsky
In reply to this post by Mark Pilgrim
Mike Beltzner wrote:
>  - controlled landing of DOMStorage (1 day?)

Note that there's at least one issue outstanding where it's not clear to me what
the spec says and our impl doesn't make that much sense to me....  Should
probably coordinate with Hixie on that if we can.

-Boris
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Neil Deakin
In reply to this post by Mike Connor-3
Mike Connor wrote:
     d) DOM Storage was backed out of both trees because of build bustage
>        and performance regressions.  Team is working on better plan for
>        build issues and will re-land once that and leak issues are
>        addressed.
>

What performance issues? DOM Storage doesn't do anything unless you call it.

And what leaks are you referring to?

/ Neil
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Mike Beltzner
In reply to this post by Boris Zbarsky
Sure, but I'd think that would be a bug on the current implementation, not a blocker of the landing itself, no?

mike
-----Original Message-----
From: Boris Zbarsky <[hidden email]>
Date: Thu, 11 May 2006 00:50:05
To:[hidden email]
Subject: Re: Plan for Fx2 Alpha 2

Mike Beltzner wrote:
>  - controlled landing of DOMStorage (1 day?)

Note that there's at least one issue outstanding where it's not clear to me what
the spec says and our impl doesn't make that much sense to me....  Should
probably coordinate with Hixie on that if we can.

-Boris
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Boris Zbarsky
In reply to this post by Boris Zbarsky
Mike Beltzner wrote:
> Sure, but I'd think that would be a bug on the current implementation, not a blocker of the landing itself, no?

If you're willing to land a patch with possible security issues, sure.

-Boris
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

schrep-2
In reply to this post by Mark Pilgrim
Thanks for getting this started.

>  - re-opening trunk (tomorrow)
>  - sync up between branch and trunk (2 days?)
>  - controlled landing of DOMStorage (1 day?)

Are we all set with landing in a way that doesn't break non-ff builds?

>  - controlled landing of SafeBrowsing (1 day?)

There are some perf/leak here that we'd need to finish first.  Not sure
how much net work there is here.

>  - re-open branch for bugfixes (2 days?)
>  - code freeze for A3 (May 23rd?)
>  - release of A3 (May 25th?)

Can we get a sense from folks about other issues that are pressing for
an a3?   Not sure how much the bugfixes section here is.

Mike


>
> Just spitballin' here.
>
> mike
>
> On 11-May-06, at 1:07 AM, Mark Pilgrim wrote:
>
>> On 5/10/06, Mike Connor <[hidden email]> wrote:
>>> We'd like DOMStorage and SafeBrowsing in a3.
>>
>> a3?
>>
>> --Cheers,
>> -Mark
>> _______________________________________________
>> dev-planning mailing list
>> [hidden email]
>> https://lists.mozilla.org/listinfo/dev-planning
>
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Boris Zbarsky
Mike Schroepfer wrote:
> Can we get a sense from folks about other issues that are pressing for
> an a3?   Not sure how much the bugfixes section here is.

I have at least two patches I'd want to get in for a3...

-Boris
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Mike Shaver
In reply to this post by Neil Deakin
On 5/11/06, Neil Deakin <[hidden email]> wrote:
> What performance issues? DOM Storage doesn't do anything unless you call it.

I thought the DOM storage code was called for storage object cloning
whenever new windows were opened (and that we had a bug on a crash in
that case, at one point).  Does that only happen if the opener had
manipulated DOM storage in some way?

Mike
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Neil Deakin
Mike Shaver wrote:

> On 5/11/06, Neil Deakin <[hidden email]> wrote:
>> What performance issues? DOM Storage doesn't do anything unless you
>> call it.
>
> I thought the DOM storage code was called for storage object cloning
> whenever new windows were opened (and that we had a bug on a crash in
> that case, at one point).  Does that only happen if the opener had
> manipulated DOM storage in some way?
>
> Mike
>

Which is why I asked which performance issues were being referred to.
The cloning currently only occurs when window.open is called.

/ Neil

_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

Robert Kaiser
In reply to this post by schrep-2
Mike Schroepfer schrieb:
>>  - controlled landing of DOMStorage (1 day?)
>
> Are we all set with landing in a way that doesn't break non-ff builds?

If https://bugzilla.mozilla.org/show_bug.cgi?id=337208 does go in, I
think it should work for everyone.

Robert Kaiser
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning
Reply | Threaded
Open this post in threaded view
|

Re: Plan for Fx2 Alpha 2

beltzner
In reply to this post by Mike Connor-3
On 5/10/06, Mike Connor <[hidden email]> wrote:

> Here's the plan for a2:
>
> We'd like to ship a2 tomorrow.  This will include SessionRestore and
> uSummaries but not DOM Storage or SafeBrowsing.   It will including the
> the leak/performance patches plus three regression fixes delivered over
> the last few days:
>      337292: Searchbar flex works better on Mac
>      336945: can't use "Use a Web Site" when no local RSS handler
>              is installed
>      337305: unhork adding a new bookmark from the bookmarks manager

Obviously this didn't happen; the QA team found some bugs that looked
like regressions and we had to stop to investigate*. Since we missed
the window for a release, we decided to pick up the May 12th morning
builds and smoketest those, targeting an early morning release of
Alpha 2. We also landed

       337548: expand the target of the search engine drop down on mac

and a temporary patch from 336273 that IFDEFs out the useless
SafeBrowsing UI until such time as we can land that piece.

cheers,
mike

(* it turned out to be related to the disabling of weak ciphers, and
not something that needs to block an alpha release)

--
/ mike beltzner / user experience lead / mozilla corporation /
_______________________________________________
dev-planning mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-planning