[Patch] Re: 2.0.0.23 problem linking to libsqlite3

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch] Re: 2.0.0.23 problem linking to libsqlite3

tjoen-3
tjoen wrote:

> 2.0.0.23 Linux gcc-4.4.0 binutils-2.19.1

> .mozconfig
> mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
> . \$topsrcdir/mail/config/mozconfig
> ac_add_options --prefix=/usr
> ac_add_options --with-system-nspr
> ac_add_options --with-system-nss # second build I deleted this line
> ac_add_options --with-system-jpeg
> ac_add_options --with-system-zlib
> ac_add_options --with-system-png
> ac_add_options --enable-default-toolkit=gtk2
> ac_add_options --enable-static-mail
> ac_add_options --disable-freetype2
> ac_add_options --enable-xft
> ac_add_options --enable-crypto
> ac_add_options --disable-installer
> ac_add_options --disable-tests
> ac_add_options --disable-debug
> ac_add_options --enable-optimize
> ac_add_options --enable-system-cairo
> mk_add_options MOZ_CO_PROJECT=mail

> ...
>  make[3]: Entering directory
>      `/home/tjoen/rpmbuild/BUILD/mozilla/objdir/storage/build'
> ...
> c++  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith \
>  -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy \
>  -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar \
>  -pthread -pipe  -DNDEBUG -DTRIMMED -O -fPIC -shared \
>  -Wl,-z,defs -Wl,-h,libstoragecomps.so \
>  -o libstoragecomps.so \
>  mozStorageModule.o \
>  -Wl,--whole-archive ../../dist/lib/libstorage_s.a \
>  -Wl,--no-whole-archive -L../../dist/bin -L../../dist/lib -lsqlite3 \
>  -L../../dist/bin -lxpcom -lxpcom_core \
>  -L../../dist/bin -L/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl \
>  -L../../dist/bin -lmozjs \
>  -Wl,--version-script \
>  -Wl,../../../build/unix/gnu-ld-scripts/components-version-script \
>  -Wl,-Bsymbolic -ldl -lm

>  ../../dist/lib/libstorage_s.a(mozStorageAsyncIO.o): In function `.L106':
> mozStorageAsyncIO.cpp:(.text+0x8a4): undefined reference to `sqlite3ApiExit'
> ...
> etc

Confirmed by toshiharu : (no .mozconfig given)
> I got the same error with gcc-4.3.3 and binutils-2.19.51.0.9.

diff -uNr mozilla.orig/db/sqlite3/src/Makefile.in mozilla/db/sqlite3/src/Makefile.in
--- mozilla.orig/db/sqlite3/src/Makefile.in     2009-08-10 19:59:12.000000000 +0200
+++ mozilla/db/sqlite3/src/Makefile.in  2009-08-24 21:53:50.000000000 +0200
@@ -46,7 +46,7 @@
 MODULE           = sqlite3
 LIBRARY_NAME     = sqlite3
 MODULE_NAME      = sqlite3
-FORCE_SHARED_LIB = 1
+FORCE_STATIC_LIB = 1
 VISIBILITY_FLAGS =

 ifeq (,$(filter-out WINNT WINCE, $(OS_ARCH)))
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Re: 2.0.0.23 problem linking to libsqlite3

Dan Mosedale-2
On 8/25/09 12:35 AM, tjoen wrote:
> [patch for 2.0.0.23 sqlite travails on Linux omitted
Would you be willing to file a bug in Bugzilla about this and submit it
as a patch?  That would be very helpful, as it would put it on the path
to getting landed in the main tree.  Feel free to cc [hidden email]
on the bug, if you wish.

Thanks!
Dan

_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Re: 2.0.0.23 problem linking to libsqlite3

tjoen-3
In reply to this post by tjoen-3
Dan Mosedale wrote:
> On 8/25/09 12:35 AM, tjoen wrote:
>> [patch for 2.0.0.23 sqlite travails on Linux omitted
> Would you be willing to file a bug in Bugzilla about this and submit it
> as a patch?

I think I have no permission for that, no account there.
But sure there are developpers reading this newsgroup/list
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Re: 2.0.0.23 problem linking to libsqlite3

Dan Mosedale-2
On 8/26/09 11:42 AM, tjoen wrote:

> Dan Mosedale wrote:
>    
>> On 8/25/09 12:35 AM, tjoen wrote:
>>      
>>> [patch for 2.0.0.23 sqlite travails on Linux omitted
>>>        
>> Would you be willing to file a bug in Bugzilla about this and submit it
>> as a patch?
>>      
> I think I have no permission for that, no account there.
>    
Fortunately, accounts are free and very easy to set up!
> But sure there are developpers reading this newsgroup/list
>    
While that's true, years of past experience shows that bug reports and
fixes that get sent to this list tend to fall off the radar, because it
really is just a discussion list, not a bug/patch tracker.  :-(

Dan
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Re: 2.0.0.23 problem linking to libsqlite3

tjoen-3
In reply to this post by tjoen-3
Dan Mosedale wrote:
> On 8/26/09 11:42 AM, tjoen wrote:
>> But sure there are developpers reading this newsgroup/list
>>    
> While that's true, years of past experience shows that bug reports and
> fixes that get sent to this list tend to fall off the radar,

Same with Bugzilla reports. The missing
#include <cstdio>
is still there
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Re: 2.0.0.23 problem linking to libsqlite3

Magnus Melin
On 27.08.2009 20:55, tjoen wrote:
> Dan Mosedale wrote:
>> On 8/26/09 11:42 AM, tjoen wrote:
>>> But sure there are developpers reading this newsgroup/list
>>>
>> While that's true, years of past experience shows that bug reports and
>> fixes that get sent to this list tend to fall off the radar,
>
> Same with Bugzilla reports.

Not true. Almost all reports with patches attached do get appropriate attention.
Since it requires a bug report for the patch to be reviewed and checked in
anyway, it's just a waste of time doing anything about it here.

  -Magnus


_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Re: 2.0.0.23 problem linking to libsqlite3

tjoen-3
Magnus Melin wrote:
> Since it requires a bug report for the patch to be reviewed
> and checked in anyway, it's just a waste of time doing anything about it
> here.

This one appears is Google, (not yet in Bing)
so everybody with the same problem can apply the patch.

But anybody with a bugzilla account can submit the patch,
that is the reason I made my OP so complete
_______________________________________________
dev-apps-thunderbird mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-apps-thunderbird