Fwd: Changes to XPCOM refcounting

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

Fwd: Changes to XPCOM refcounting

Patrick McManus
in case you didn't see this on dev-platform.. this affects a lot of necko
code as we heavily utilize multiple threads.

---------- Forwarded message ----------
From: Joshua Cranmer 🐧 <[hidden email]>
Date: Tue, Jul 23, 2013 at 2:22 PM
Subject: Changes to XPCOM refcounting
To: [hidden email]

As part of an effort to remove use of the NSPR atomic macros in favor of
mozilla::Atomic, the way that threadsafe reference counting works in XPCOM
has changed. Whereas before, this was done using the macros by saying
NS_IMPL_THREADSAFE_ISUPPORTSN (or related macros), now the threadsafe
declaration has been changed to NS_DECL_THREADSAFE_ISUPPORTS in the class
body. All of the affected NS_IMPL_THREADSAFE macros have been removed as a
result, which may cause some patch bustage.

Also related to this change, the NS_AtomicRefcnt functions and
nsAtomicRefcnt.h itself have been removed (use
mozilla::ThreadSafeAutoRefcnt instead).

This change is being tracked in bug 884061 and has landed in
mozilla-inbound already.

Joshua Cranmer
Thunderbird and DXR developer
Source code archæologist

dev-platform mailing list
[hidden email]
dev-tech-network mailing list
[hidden email]