Firefox 52 release contains unrelased NSPR changes

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Firefox 52 release contains unrelased NSPR changes

Kai Engert-4
Unfortunately, Firefox 52 has been released with the following two changes to
NSPR, without having been released with NSPR yet:

(a) https://hg.mozilla.org/mozilla-central/diff/da9997b39928/nsprpub/pr/include/prio.h
(b) https://hg.mozilla.org/mozilla-central/diff/b70e2870aced/nsprpub/pr/src/md/windows/w32poll.c
  (context: https://bugzilla.mozilla.org/show_bug.cgi?id=1288308#c58 )

In addition, the same mistake was made for Firefox 54 (unreleased, currently in
alpha/aurora phase):

(c) https://hg.mozilla.org/mozilla-central/rev/9882b8c0d5fb
  (context: https://bugzilla.mozilla.org/show_bug.cgi?id=1331810#c4 )


We need to clean that up with a NSPR release, that has as little risks as
possible, because we should land it into Firefox 54, and potentially we might
want to uplift the same NSPR version into the earlier branches, like Firefox 53,
or even the long-lived Firefox 52 ESR branch.

Therefore I suggest that we release a NSPR 4.14 version, which is based on the
most recent release NSPR 4.13.1, plus the above changes, plus a completeness
change that Wan-Teh had suggested for (a/b).

I have already checked in those changes to a new NSPR 4.14 branch:
https://hg.mozilla.org/projects/nspr/graph


There's a remaining detail I'd like to discuss:

Commit (a) changed the size of PRNetAddr on Windows.
It would be easiest, if we could simply pick up that change.

However, is that change acceptable for NSPR?

Or is there anyone on Windows who ships NSPR binaries separately from
applications and requires forward compatibility? I guess that would only be a
concern, if an application allocated this structure, and passed it to the
library. Is this ever happening?

Kai

_______________________________________________
dev-tech-nspr mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-nspr
Reply | Threaded
Open this post in threaded view
|

Re: Firefox 52 release contains unrelased NSPR changes

Kai Engert-4
FYI, there's the suggestion to prevent this from happening in the future, by
using a commit hook, detecting unauthorized changes to the copy of NSPR used by
the Firefox repository.
https://bugzilla.mozilla.org/show_bug.cgi?id=1348852

_______________________________________________
dev-tech-nspr mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-nspr
Reply | Threaded
Open this post in threaded view
|

Re: Firefox 52 release contains unrelased NSPR changes

Kai Engert-4
In reply to this post by Kai Engert-4
On Tue, 2017-03-21 at 12:49 +0100, Kai Engert wrote:

> ...
>
> (a) https://hg.mozilla.org/mozilla-central/diff/da9997b39928/nsprpub/pr/includ
> e/prio.h
> ...
>
> Commit (a) changed the size of PRNetAddr on Windows.
> It would be easiest, if we could simply pick up that change.
>
> However, is that change acceptable for NSPR?
>
> Or is there anyone on Windows who ships NSPR binaries separately from
> applications and requires forward compatibility? I guess that would only be a
> concern, if an application allocated this structure, and passed it to the
> library. Is this ever happening?

I'm hoping for some comments on this detail.

We should try to release NSPR 4.14 very soon, possibly by Thursday.

After the release is done, we'd like to start testing the other recent changes
to NSPR with mozilla-central, for preparing a NSPR 4.15 release.

Thanks
Kai

_______________________________________________
dev-tech-nspr mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-nspr
Reply | Threaded
Open this post in threaded view
|

Re: Firefox 52 release contains unrelased NSPR changes

Kai Engert-4
There was no reply.
In discussions with other developers, nobody thought it's necessary to keep this
PRNetAddr frozen on Windows.
We'll go ahead with creating the release.

Kai

_______________________________________________
dev-tech-nspr mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-tech-nspr