Feed parser has tests!

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Feed parser has tests!

Dave Liebreich
Cool.

http://lxr.mozilla.org/seamonkey/source/toolkit/components/feeds/test/

--
Dave Liebreich
Test Architect, Mozilla Corporation
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Rob Sayre-2
Dave Liebreich wrote:
> Cool.
>
> http://lxr.mozilla.org/seamonkey/source/toolkit/components/feeds/test/
>

Yes. But the exectests.sh script in that directory is not so cool :/

I know there are several in-progress efforts around unit testing. Which
one should I be tracking? I can't wait to delete my lame bash script.

-Rob
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Dave Liebreich
Robert Sayre wrote:

> Yes. But the exectests.sh script in that directory is not so cool :/


As a tiny step forward, I've got a simple patch to remove it and run
from a makefile target.  Should I file a bug?


--
Dave Liebreich
Test Architect, Mozilla Corporation
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Rob Sayre-2
Dave Liebreich wrote:
> Robert Sayre wrote:
>
>> Yes. But the exectests.sh script in that directory is not so cool :/
>
> As a tiny step forward, I've got a simple patch to remove it and run
> from a makefile target.  Should I file a bug?

Yes, definitely.

-Rob

_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Dave Liebreich
Robert Sayre wrote:

> Dave Liebreich wrote:
>> Robert Sayre wrote:
>>
>>> Yes. But the exectests.sh script in that directory is not so cool :/
>>
>> As a tiny step forward, I've got a simple patch to remove it and run
>> from a makefile target.  Should I file a bug?
>
> Yes, definitely.
>
> -Rob
>

https://bugzilla.mozilla.org/show_bug.cgi?id=337216

--
Dave Liebreich
Test Architect, Mozilla Corporation
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Axel Hecht
In reply to this post by Dave Liebreich
Dave Liebreich wrote:
> Cool.
>
> http://lxr.mozilla.org/seamonkey/source/toolkit/components/feeds/test/
>

The feed tests should really include the feeds we have in our
repository, i.e.

http://lxr.mozilla.org/l10n-mozilla1.8.0/search?string=feedurl%3D

There are two feeds with issues, german (de) and norwegian (nn-NO).

German has discoverability and encoding issues (bugs filed),
http://www.nrk.no/nyheiter/siste.rss has newlines in the titles, which
mess up the livemark.

Axel
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Dave Liebreich
Axel Hecht wrote:
> Dave Liebreich wrote:
>> Cool.
>>
>> http://lxr.mozilla.org/seamonkey/source/toolkit/components/feeds/test/
>>
>
> The feed tests should really include the feeds we have in our
> repository, i.e.

I'd rephrase that:

When we find a bug in feed parsing, we should add a test case that
covers that bug.

Relying on an external feed to remain constant is a bad idea.

>
> http://lxr.mozilla.org/l10n-mozilla1.8.0/search?string=feedurl%3D
>
> There are two feeds with issues, german (de) and norwegian (nn-NO).
>
> German has discoverability and encoding issues (bugs filed),
> http://www.nrk.no/nyheiter/siste.rss has newlines in the titles, which
> mess up the livemark.

bug #s?

>
> Axel


--
Dave Liebreich
Test Architect, Mozilla Corporation
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Axel Hecht
Dave Liebreich wrote:

> Axel Hecht wrote:
>> Dave Liebreich wrote:
>>> Cool.
>>>
>>> http://lxr.mozilla.org/seamonkey/source/toolkit/components/feeds/test/
>>>
>>
>> The feed tests should really include the feeds we have in our
>> repository, i.e.
>
> I'd rephrase that:
>
> When we find a bug in feed parsing, we should add a test case that
> covers that bug.
>
> Relying on an external feed to remain constant is a bad idea.
>

There are two kinds of tests, one is, feature tests. The other is, real
life tests.
And we do need the real life tests, whether that is due to the content
changing or us doesn't matter a bit in the end, we need to work on the
feeds we ship.

>>
>> http://lxr.mozilla.org/l10n-mozilla1.8.0/search?string=feedurl%3D
>>
>> There are two feeds with issues, german (de) and norwegian (nn-NO).
>>
>> German has discoverability and encoding issues (bugs filed),
>> http://www.nrk.no/nyheiter/siste.rss has newlines in the titles, which
>> mess up the livemark.
>
> bug #s?

https://bugzilla.mozilla.org/show_bug.cgi?id=337291
https://bugzilla.mozilla.org/show_bug.cgi?id=337297, duped to
https://bugzilla.mozilla.org/show_bug.cgi?id=324961, which is happily
waiting for regressions to pop up and didn't make a2.

This is not all, though. es-AR and he do show problems, too. Bottom
line, they're not tested. Bad.

Axel
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Axel Hecht
Axel Hecht wrote:

> Dave Liebreich wrote:
>> Axel Hecht wrote:
>>> Dave Liebreich wrote:
>>>> Cool.
>>>>
>>>> http://lxr.mozilla.org/seamonkey/source/toolkit/components/feeds/test/
>>>>
>>>
>>> The feed tests should really include the feeds we have in our
>>> repository, i.e.
>>
>> I'd rephrase that:
>>
>> When we find a bug in feed parsing, we should add a test case that
>> covers that bug.
>>
>> Relying on an external feed to remain constant is a bad idea.
>>
>
> There are two kinds of tests, one is, feature tests. The other is, real
> life tests.
> And we do need the real life tests, whether that is due to the content
> changing or us doesn't matter a bit in the end, we need to work on the
> feeds we ship.
>
>>>
>>> http://lxr.mozilla.org/l10n-mozilla1.8.0/search?string=feedurl%3D
>>>
>>> There are two feeds with issues, german (de) and norwegian (nn-NO).
>>>
>>> German has discoverability and encoding issues (bugs filed),
>>> http://www.nrk.no/nyheiter/siste.rss has newlines in the titles,
>>> which mess up the livemark.
>>
>> bug #s?
>
> https://bugzilla.mozilla.org/show_bug.cgi?id=337291
> https://bugzilla.mozilla.org/show_bug.cgi?id=337297, duped to
> https://bugzilla.mozilla.org/show_bug.cgi?id=324961, which is happily
> waiting for regressions to pop up and didn't make a2.
>
> This is not all, though. es-AR and he do show problems, too. Bottom
> line, they're not tested. Bad.
>
> Axel

Filed meta-bugish 337352

Axel
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality
Reply | Threaded
Open this post in threaded view
|

Re: Feed parser has tests!

Rob Sayre-2
Axel Hecht wrote:
>
> Filed meta-bugish 337352

Livemarks don't use the toolkit code yet, and it's not planned to move
them to it until after FF2.

The only bug I see that I can unit test is the RTL bug. Right now, we're
stripping all markup, so the RTL div naturally gets dropped, too.

-Rob
_______________________________________________
dev-quality mailing list
[hidden email]
https://lists.mozilla.org/listinfo/dev-quality